From: Jeremy Linton <jeremy.linton@arm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com,
jirislaby@kernel.org, miquel.raynal@bootlin.com,
phil.edworthy@renesas.com, kernel@esmil.dk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "serial: 8250: dw: Move the USR register to pdata"
Date: Wed, 29 Jun 2022 09:38:07 -0500 [thread overview]
Message-ID: <08505fe6-ae2a-0890-ab11-899eb4d74dc5@arm.com> (raw)
In-Reply-To: <YrvsW7RmHRr5zbS3@kroah.com>
Hi,
On 6/29/22 01:08, Greg KH wrote:
> On Tue, Jun 28, 2022 at 07:02:31PM -0500, Jeremy Linton wrote:
>> pdata is only setup by DT machines, leaving ACPI machines
>> with null pdata. Since I don't know the exact mapping of
>> ACPI ID's to dw 8250 variations I can't add pdata to them
>> without possibly breaking something. As such the simplest
>> fix here is probably just to revert this commit.
>>
>> This reverts commit ffd381445eac2aa624e49bab5a811451e8351008.
>> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>
> Didn't checkpatch complain that you need a blank line before your
> signed-off-by line?
No, it, and I apparently thought that the revert was part of the tagging.
Lets kill this set anyway, as the patch you already have to add pdata to
ACPI in tty-linus solves all these problems. I guess I missed that
posting, so sorry about the noise.
Thanks,
next prev parent reply other threads:[~2022-06-29 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 0:02 [PATCH 0/2] BUG, more dw8259 ACPI crashes Jeremy Linton
2022-06-29 0:02 ` [PATCH 1/2] Revert "serial: 8250: dw: Move the USR register to pdata" Jeremy Linton
2022-06-29 6:08 ` Greg KH
2022-06-29 14:38 ` Jeremy Linton [this message]
2022-06-29 0:02 ` [PATCH 2/2] serial: 8250: dw: Fix NULL pointer dereference Jeremy Linton
2022-06-29 8:01 ` Ilpo Järvinen
2022-06-29 7:43 ` [PATCH 0/2] BUG, more dw8259 ACPI crashes Miquel Raynal
2022-06-29 14:37 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08505fe6-ae2a-0890-ab11-899eb4d74dc5@arm.com \
--to=jeremy.linton@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox