From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762241AbdAKLQS (ORCPT ); Wed, 11 Jan 2017 06:16:18 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49460 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756327AbdAKLQQ (ORCPT ); Wed, 11 Jan 2017 06:16:16 -0500 Subject: Re: [PATCH v4 0/3] perf: add support for analyzing events for containers To: Krister Johansen , Hari Bathini References: <148182699546.5314.279803283347257825.stgit@hbathini.in.ibm.com> <20161229014138.GB2341@templeofstupid.com> <40b222dc-5149-4f82-4d5e-6a8d188a6a35@linux.vnet.ibm.com> <20170104090459.GB3009@templeofstupid.com> Cc: ast@fb.com, peterz@infradead.org, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , ebiederm@xmission.com, sargun@sargun.me, brendan.d.gregg@gmail.com, rgb@redhat.com, Linux-audit@redhat.com From: Aravinda Prasad Date: Wed, 11 Jan 2017 16:46:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104090459.GB3009@templeofstupid.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011111-0056-0000-0000-0000026F0B4D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006413; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000199; SDB=6.00806102; UDB=6.00392241; IPR=6.00583438; BA=6.00005047; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013888; XFM=3.00000011; UTC=2017-01-11 11:16:13 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011111-0057-0000-0000-000006A415BD Message-Id: <0856f77e-0a9c-de9a-fc67-64759e87f82e@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-11_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701110161 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 04 January 2017 02:34 PM, Krister Johansen wrote: > On Tue, Jan 03, 2017 at 04:57:54PM +0530, Hari Bathini wrote: >> On Thursday 29 December 2016 07:11 AM, Krister Johansen wrote: >>> On Fri, Dec 16, 2016 at 12:06:55AM +0530, Hari Bathini wrote: >>>> This patch-set overcomes this limitation by using cgroup identifier as >>>> container unique identifier. A new PERF_RECORD_NAMESPACES event that >>>> records namespaces related info is introduced, from which the cgroup >>>> namespace's device & inode numbers are used as cgroup identifier. This >>>> is based on the assumption that each container is created with it's own >>>> cgroup namespace allowing assessment/analysis of multiple containers >>>> using cgroup identifier. >>> Why choose cgroups when the kernel dispenses namespace-unique >>> identifiers. Cgroup membership can be arbitrary. Moreover, cgroup and >> >> Agreed. But doesn't that hold for any other namespace or a combination >> of namespaces as well? > > I guess that's part of my concern. There is no container-unique > identifier on the system, since the notion of containers is a construct > of higer-level software. I wish we had a container-unique identifier. A container-unique identifier will make things a lot more better, not just for container-aware tracing but for audit subsystem as well. https://lwn.net/Articles/699819/#Comments -- Regards, Aravinda