Re: [PATCH v5 00/26] Generic `Allocator` support for Rust

Danilo Krummrich
2024-08-15T02:52:49Z

On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote:
> Hi Danilo,
>
> I'm trying to put your series on rust-dev, but I hit a few conflicts due
> to the conflict with `Box::drop_contents`, which has been in rust-dev
> for a while. And the conflict is not that trivial for me to resolve.
> So just a head-up, that's a requirement for me to put it on rust-dev for
> more tests from my end ;-)

I rebased everything and you can fetch them from [1].

I resolved the following conflicts:

- for `Box`, implement
- `drop_contents`
- `manually_drop_contents` [2]
- ``move_out` [2]
- `BorrowedMut` for `ForeignOwnable` for `Box<T, A>` and `Pin<Box<T, A>>`
- `InPlaceWrite` and updated `InPlaceInit`
- for `RBTreeNode`, make use of `Box::move_out` to replace the original
implementation partially moving out of `Box`

@Alice: Please have a look at the changes for `RBTreeNode`. Maybe it's also
worth having them in a separate patch.

- Danilo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust-dev/mm
[2] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/commit/?h=rust-dev/mm&id=ef80ccca2ccebf3c7bcafdc13d1bfe81341cbe63
[3] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/diff/rust/kernel/rbtree.rs?h=rust-dev/mm&id=c361d66df7fb7760064fbca6bf9d72171c352a73

>
> Regards,
> Boqun