From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E92541CDA3B; Tue, 19 Nov 2024 13:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732024311; cv=none; b=sN7waC45rvYCjPihuTKlx/lXbRRHrAPZVqmdLbF7WPK6JZjpm2ropelyN4uYvz+MGsITMSTZldHDgfOxKZbYVwR3nXBFaF4o7PLeDnEkYY+wjb6IYsUMVi1S2PZXt9dMyOC0z1qppB0yR779CbhCz7dYvG4gEh3HtWZbBa5GHXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732024311; c=relaxed/simple; bh=QOPd2fVeUYrn4fIboHHWZsjCq3g3VbqNih5yxq9ztQ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rppE5iQ/6xz/rJh7BOyfSNKSIa05RkExL2Q+zDTJevEnfXhHSruWa421v6rstFElUTtPVrF2XjfbCEAaQedGyeebk+dOxIOR7I9jDx6njwiFyivXjKqkzzb3yeeDVDadsXAeHCe3yAv4Ob9hzyeajMRTgtDFRNFdHHP4TEc29lQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QH28NMWK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QH28NMWK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88965C4CED0; Tue, 19 Nov 2024 13:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732024310; bh=QOPd2fVeUYrn4fIboHHWZsjCq3g3VbqNih5yxq9ztQ4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QH28NMWKFmMo6lasjGxd5qszGhw9uSB4kH//w70dOMEyN0CuFpJiYwfLfEDN5Mz7k riUIYuO0iXOb+jeUvUOyK8Qo5MtvTRE7+HMi55yC67wg5tNul1xVsEwuwPAcTSZHKJ L/Mq+eUHeBsCiEmpDDGokO8OjGkxBq5QR9XizI9XAxLY7e8fMjyOvm9CWZohRJdnaq ZkcN9IxQyuwIfiIFvpURIFQ6zG7Od8xUEuWwN5EdCG5cOPyTcaD0AkdqNR3ZI9g8ES XnGwN4NN8HpiL3W4y/S0VdBib3Zi0Q8Zjz3z7/Fbc54FNPmpUFpVhYNlYZV+BJZ2i/ sqZdODZmw8Aww== Message-ID: <0868a2b6-5b1c-4cdd-9f87-808b4a00914e@kernel.org> Date: Tue, 19 Nov 2024 14:51:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/7] pinctrl: s32: convert the driver into an mfd cell To: Andrei Stefanescu , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Larisa Grigore , Greg Kroah-Hartman , "Rafael J. Wysocki" , Lee Jones , Shawn Guo , Sascha Hauer , Fabio Estevam , Dong Aisheng , Jacky Bai Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Pengutronix Kernel Team , imx@lists.linux.dev References: <20241113101124.1279648-1-andrei.stefanescu@oss.nxp.com> <20241113101124.1279648-5-andrei.stefanescu@oss.nxp.com> <2ccbf862-2b3e-4c08-b6bd-d9571e88a675@kernel.org> <34ec26f5-25c1-4510-a4df-caffb75a3d9e@oss.nxp.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <34ec26f5-25c1-4510-a4df-caffb75a3d9e@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/11/2024 10:57, Andrei Stefanescu wrote: > Hi Krzysztof, > >>> + if (npins < 0) >>> + return dev_err_probe(dev, -EINVAL, >>> + "Failed to read 'pinmux' in node %s\n", >>> + grp->data.name); >> >> I do not see how this change is related. Looks you are mixing cleanups >> with refactoring into MFD cell. These are two different things. > > Yes, I also included some small refactoring changes. I didn't think they were > important enough to include them in a separate commit. Would you like me to separate > them in another commit? You cannot include such changes along other, meaningful changes. This does not apply to this patch only but all contributions. There is a clear policy how cleanups, bugs and new things are being upstreamed: https://elixir.bootlin.com/linux/v6.12/source/Documentation/process/submitting-patches.rst#L168 Please read above document very carefully. This is v6 and we still circle around absolute basics. > >>> - if (mem_regions == 0 || mem_regions >= 10000) { >>> - dev_err(&pdev->dev, "mem_regions is invalid: %u\n", mem_regions); >>> - return -EINVAL; >>> - } >>> + /* one MSCR and one IMCR region per SIUL2 module */ >> >> How is this related to converion into MFD cell? > > We no longer parse the device tree to configure the regmaps, we instead > get them from the mfd driver. This is the main point of converting this > driver into an mfd cell. > >> >> Still looks like an ABI break. >> > > Yes, the driver no longer adheres to the nxp,s32g2-siul2-pinctrl.yaml binding. I did not find in commit msg explanation that this is ABI break and why it is allowed. I asked for it. > > The intention is to deprecate that binding since it doesn't correctly describe > the hardware. I am not sure on how to do this. I thought that changing this > driver and removing the old compatible would be enough. No, you cannot break the ABI. Either you deprecate this or just don't touch. > > Would it be better to add another file which would contain the old probing > function(and match the old binding) so clients would be able to select the > old implementation? I don't understand that. Your driver is supposed to keep ABI. Not through some selection but just as is. Best regards, Krzysztof