From: David Ahern <dsahern@gmail.com>
To: linmiaohe <linmiaohe@huawei.com>,
"pablo@netfilter.org" <pablo@netfilter.org>
Cc: "kadlec@blackhole.kfki.hu" <kadlec@blackhole.kfki.hu>,
"fw@strlen.de" <fw@strlen.de>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuznet@ms2.inr.ac.ru" <kuznet@ms2.inr.ac.ru>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mingfangsen <mingfangsen@huawei.com>
Subject: Re: [PATCH v4] net: netfilter: Fix rpfilter dropping vrf packets by mistake
Date: Sat, 29 Jun 2019 06:19:22 -0600 [thread overview]
Message-ID: <08740476-acfb-d35a-50b7-3aee42f23bfa@gmail.com> (raw)
In-Reply-To: <2213b3e722a14ee48768ecc7118efc46@huawei.com>
On 6/28/19 8:13 PM, linmiaohe wrote:
> You're right. Fib rules code would set FLOWI_FLAG_SKIP_NH_OIF flag. But I set
> it here for distinguish with the flags & XT_RPFILTER_LOOSE branch. Without
> this, they do the same work and maybe should be combined. I don't want to
> do that as that makes code confusing.
> Is this code snipet below ok ? If so, I would delete this flag setting.
>
> } else if (netif_is_l3_master(dev) || netif_is_l3_slave(dev)) {
> fl6.flowi6_oif = dev->ifindex;
> } else if ((flags & XT_RPFILTER_LOOSE) == 0)
> fl6.flowi6_oif = dev->ifindex;
that looks fine to me, but it is up to Pablo.
next prev parent reply other threads:[~2019-06-29 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 2:13 [PATCH v4] net: netfilter: Fix rpfilter dropping vrf packets by mistake linmiaohe
2019-06-29 12:19 ` David Ahern [this message]
2019-06-29 14:13 ` 答复: " linmiaohe
2019-07-01 18:01 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2019-06-28 9:06 Miaohe Lin
2019-06-28 17:04 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08740476-acfb-d35a-50b7-3aee42f23bfa@gmail.com \
--to=dsahern@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox