public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: rafael@kernel.org, viresh.kumar@linaro.org, tglx@linutronix.de,
	 mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
	 linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [PATCH 1/2] x86/cpufeatures: Add HWP highest perf change feature flag
Date: Tue, 18 Jun 2024 03:25:11 -0700	[thread overview]
Message-ID: <087eb35754ddd8dde74c55ac7783fe42f48b7f82.camel@linux.intel.com> (raw)
In-Reply-To: <20240618090739.GAZnFOW6FRwcE5EkQI@fat_crate.local>

On Tue, 2024-06-18 at 11:07 +0200, Borislav Petkov wrote:
> On Mon, Jun 17, 2024 at 08:51:20PM -0700, Srinivas Pandruvada wrote:
> > When CPUID[6].EAX[15] is set to 1, this CPU supports notification
> > for
> > HWP (Hardware P-states) highest performance change.
> > 
> > Add a feature flag to check if the CPU supports HWP highest
> > performance
> > change.
> > 
> > 

[...]

> > +#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* HWP
> > Highest perf change */
> 
> Doesn't belong in /proc/cpuinfo:
> 
> #define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* "" HWP
> Highest perf change */
> 
>                                                         ^^^^^

Thanks for pointing this out. Will update in v2.

-Srinivas

> 
> 


  reply	other threads:[~2024-06-18 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  3:51 [PATCH 0/2] Update highest frequency of a CPU after boot Srinivas Pandruvada
2024-06-18  3:51 ` [PATCH 1/2] x86/cpufeatures: Add HWP highest perf change feature flag Srinivas Pandruvada
2024-06-18  9:07   ` Borislav Petkov
2024-06-18 10:25     ` srinivas pandruvada [this message]
2024-06-18  3:51 ` [PATCH 2/2] cpufreq: intel_pstate: Support highest performance change interrupt Srinivas Pandruvada
2024-06-18  9:08   ` Borislav Petkov
2024-06-18 10:11     ` srinivas pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=087eb35754ddd8dde74c55ac7783fe42f48b7f82.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox