* [PATCH] sb_edac: Fix typo computing number of banks
@ 2014-12-02 17:41 Tony Luck
2014-12-02 18:17 ` Aristeu Rozanski
0 siblings, 1 reply; 3+ messages in thread
From: Tony Luck @ 2014-12-02 17:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Doug Thompson, Borislav Petkov, Aristeu Rozanski, linux-edac,
linux-kernel
Code will always think there are 16 banks because of a typo
Reported-by: Misha
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Not sure if Misha is shy, or just busy. But my attempt to get
them to post their own patch didn't work
drivers/edac/sb_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 993e8b61c4b2..63aa6730e89e 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -901,7 +901,7 @@ static int get_dimm_config(struct mem_ctl_info *mci)
else
edac_dbg(0, "Memory is unregistered\n");
- if (mtype == MEM_DDR4 || MEM_RDDR4)
+ if (mtype == MEM_DDR4 || mtype == MEM_RDDR4)
banks = 16;
else
banks = 8;
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sb_edac: Fix typo computing number of banks
2014-12-02 17:41 [PATCH] sb_edac: Fix typo computing number of banks Tony Luck
@ 2014-12-02 18:17 ` Aristeu Rozanski
2014-12-02 19:04 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Aristeu Rozanski @ 2014-12-02 18:17 UTC (permalink / raw)
To: Tony Luck
Cc: Mauro Carvalho Chehab, Doug Thompson, Borislav Petkov, linux-edac,
linux-kernel
On Tue, Dec 02, 2014 at 09:41:58AM -0800, Tony Luck wrote:
> Code will always think there are 16 banks because of a typo
>
> Reported-by: Misha
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>
> Not sure if Misha is shy, or just busy. But my attempt to get
> them to post their own patch didn't work
>
> drivers/edac/sb_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 993e8b61c4b2..63aa6730e89e 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -901,7 +901,7 @@ static int get_dimm_config(struct mem_ctl_info *mci)
> else
> edac_dbg(0, "Memory is unregistered\n");
>
> - if (mtype == MEM_DDR4 || MEM_RDDR4)
> + if (mtype == MEM_DDR4 || mtype == MEM_RDDR4)
> banks = 16;
> else
> banks = 8;
ACK
--
Aristeu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sb_edac: Fix typo computing number of banks
2014-12-02 18:17 ` Aristeu Rozanski
@ 2014-12-02 19:04 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-02 19:04 UTC (permalink / raw)
To: Aristeu Rozanski
Cc: Tony Luck, Doug Thompson, Borislav Petkov, linux-edac,
linux-kernel
Em Tue, 2 Dec 2014 13:17:58 -0500
Aristeu Rozanski <aris@redhat.com> escreveu:
> On Tue, Dec 02, 2014 at 09:41:58AM -0800, Tony Luck wrote:
> > Code will always think there are 16 banks because of a typo
> >
> > Reported-by: Misha
> > Signed-off-by: Tony Luck <tony.luck@intel.com>
Applied, thanks!
> > ---
> >
> > Not sure if Misha is shy, or just busy. But my attempt to get
> > them to post their own patch didn't work
> >
> > drivers/edac/sb_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> > index 993e8b61c4b2..63aa6730e89e 100644
> > --- a/drivers/edac/sb_edac.c
> > +++ b/drivers/edac/sb_edac.c
> > @@ -901,7 +901,7 @@ static int get_dimm_config(struct mem_ctl_info *mci)
> > else
> > edac_dbg(0, "Memory is unregistered\n");
> >
> > - if (mtype == MEM_DDR4 || MEM_RDDR4)
> > + if (mtype == MEM_DDR4 || mtype == MEM_RDDR4)
> > banks = 16;
> > else
> > banks = 8;
>
> ACK
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-02 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-02 17:41 [PATCH] sb_edac: Fix typo computing number of banks Tony Luck
2014-12-02 18:17 ` Aristeu Rozanski
2014-12-02 19:04 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox