From: Edward Cree <ecree.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Bo Liu <liubo03@inspur.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfc: Fix double word in comments
Date: Tue, 4 Nov 2025 17:40:42 +0000 [thread overview]
Message-ID: <08951e84-24f4-4708-82e9-d23147d0c352@gmail.com> (raw)
In-Reply-To: <20251103162416.788bca9f@kernel.org>
On 04/11/2025 00:24, Jakub Kicinski wrote:
> On Wed, 29 Oct 2025 15:21:31 +0800 Bo Liu wrote:
>> Remove the repeated word "the" in comments.
>>
>> Signed-off-by: Bo Liu <liubo03@inspur.com>
>
> If you're doing typo-style fixes please fix all of the problems in
> the file.
FWIW this file is automatically generated from definitions managed
by the sfc firmware team, so typo fixes need to go to that upstream
source or they will just be overwritten next time the file is
regenerated. (We have tweaked the script to add a comment at the
top of the file explaining this, but we haven't pushed out a header
regeneration patch since then so it's not there yet.)
If Liu does produce a comprehensive typo-fix patch, I will do the
work to upstream the changes. But it doesn't seem worth it for a
single fix like this.
-ed
prev parent reply other threads:[~2025-11-04 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 7:21 [PATCH] sfc: Fix double word in comments Bo Liu
2025-11-04 0:24 ` Jakub Kicinski
2025-11-04 17:40 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08951e84-24f4-4708-82e9-d23147d0c352@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=liubo03@inspur.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox