From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Clark <robdclark@chromium.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 12/13] dt-bindings: drm/msm/gpu: Extend bindings for chip-id
Date: Fri, 28 Jul 2023 09:27:47 +0200 [thread overview]
Message-ID: <08cd9bb5-678f-e03e-4598-dd1785f0d7a7@linaro.org> (raw)
In-Reply-To: <20230727212208.102501-13-robdclark@gmail.com>
On 27/07/2023 23:20, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Upcoming GPUs use an opaque chip-id for identifying the GPU.
Examples?
Anyway, I think we should insist here of using something human-readable,
even if Qualcomm/Adreno internally use some weird numbers.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 58ca8912a8c3..56b9b247e8c2 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -13,6 +13,12 @@ maintainers:
> properties:
> compatible:
> oneOf:
> + - description: |
> + The driver is parsing the compat string for Adreno to
> + figure out the chip-id.
> + items:
> + - pattern: '^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$'
{8} should work?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-28 7:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 21:20 [PATCH v2 00/13] drm/msm/adreno: Move away from legacy revision matching Rob Clark
2023-07-27 21:20 ` [PATCH v2 01/13] drm/msm/adreno: Remove GPU name Rob Clark
2023-07-27 21:20 ` [PATCH v2 02/13] drm/msm/adreno: Remove redundant gmem size param Rob Clark
2023-07-27 22:07 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 03/13] drm/msm/adreno: Remove redundant revn param Rob Clark
2023-07-27 21:20 ` [PATCH v2 04/13] drm/msm/adreno: Use quirk identify hw_apriv Rob Clark
2023-07-27 21:20 ` [PATCH v2 05/13] drm/msm/adreno: Use quirk to identify cached-coherent support Rob Clark
2023-07-27 22:08 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 06/13] drm/msm/adreno: Allow SoC specific gpu device table entries Rob Clark
2023-07-27 22:12 ` Dmitry Baryshkov
2023-07-28 15:43 ` Rob Clark
2023-07-27 21:20 ` [PATCH v2 07/13] drm/msm/adreno: Move speedbin mapping to device table Rob Clark
2023-07-27 22:12 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 08/13] drm/msm/adreno: Bring the a630 family together Rob Clark
2023-07-27 21:20 ` [PATCH v2 09/13] drm/msm/adreno: Add adreno family Rob Clark
2023-07-27 22:15 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 10/13] drm/msm/adreno: Add helper for formating chip-id Rob Clark
2023-07-27 21:20 ` [PATCH v2 11/13] drm/msm/adreno: Move adreno info to config Rob Clark
2023-07-27 22:50 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 12/13] dt-bindings: drm/msm/gpu: Extend bindings for chip-id Rob Clark
2023-07-28 7:27 ` Krzysztof Kozlowski [this message]
2023-07-28 15:29 ` Rob Clark
2023-07-27 21:20 ` [PATCH v2 13/13] drm/msm/adreno: Switch to chip-id for identifying GPU Rob Clark
2023-08-04 15:28 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cd9bb5-678f-e03e-4598-dd1785f0d7a7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox