From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B0D9146D7E for ; Mon, 14 Oct 2024 08:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728895647; cv=none; b=qHZn5BuzZ9cmc67iC/Y8S4Fqm2f/cWjn9iiFzDiIe2jb5kiDHIF2JTmjMugz1GsUyrM8pQ7v+rgz/RKDdNK8DuMUrOj1EmKCZrzsB5KeQ6oLuaSXBregABDPEjK0hjkdCKi9LzrigQZJWQGyxQ+5iX7wdPKBviMS2KmK37MFv34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728895647; c=relaxed/simple; bh=CKAAFTOaYXzss3hbLk4LijIqfj37lvrsTUlUC26hYX8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pc849uvlU04Ug2vVbVRs5AfNdqMrX4I0App0QomlD4kvFJ1qf/S9prB23A9QbczbczPuUO/1Px/MDd8utB0zvEgPrxHNE4cXphydqHgzBW6I8l9T+EQZnQsPl+hn7HSVWJuxpYWBl2XJeXl9N9pQkAFHYijdvaxETsv0tLgIJ/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z5glFQD7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z5glFQD7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728895644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHHrpd04LCN5U9FT9iT5XYMMgwb+6uYYFSdfvRXUjCQ=; b=Z5glFQD73M+VyIL6QXQRmcjo6SQyHUdhI598qG+LBJHcjhYiqZ++cFQi5BQIEarDXstr4j dxNAZEN7Iimx43Fjn/Hk1xZ7LYwx6wdNEA6ZeeUnb5fk7m/ayZBIbwAJUZOnOyzPOEZUqw 3mfcjyL04mpfr7nBMjMmCn4bk5myH50= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-K7DexFfmOeutJNJe-ZcsFA-1; Mon, 14 Oct 2024 04:47:23 -0400 X-MC-Unique: K7DexFfmOeutJNJe-ZcsFA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-539e91e12bbso1014946e87.2 for ; Mon, 14 Oct 2024 01:47:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728895642; x=1729500442; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EHHrpd04LCN5U9FT9iT5XYMMgwb+6uYYFSdfvRXUjCQ=; b=h8cIfo8m8Bh+lj9f0jGcc3sh4vESKWViF9cXndZomCo3/1YDHInQKcbrZ2gvx2KXiv wJkiw1CT3ZDtgH1RrKi/CeFpo1f9YxL08POG3LgH8cyfa1Czv28o4VH/tNtxIDrIYrGR l1G1VgZZVQsNqt2tixrwHYJK4QWrR4DpnOaClybUCTYqqhcu5K0OmjRlcJ29Pk9fFpNg H5crBANPvos6ZxAs3qKdbJMOiPeTQkhHG6FnO7dftnBIbS7CYniNceO0L32G1SZQKxex FS7REZxy6bXA4kmR+iYxkTc85v+NLp+8l3N7XS6PIdriC9FQqiKJPkFCJC10ipuebUjS 5Gdg== X-Forwarded-Encrypted: i=1; AJvYcCWQYbPOX1TzdA3ViTB0z//DeJeCXXV06ozBS0powdaLk5xKUjsuvkJqPyxtqijah9BwU/Jns9RjJn4edhM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpi3fbT6OlxlHlNcSukZ1CuNl81pw0XUvoSwiPpk0wmsH0ZjId dYr9/OBCGsanndA82VWa5bWyXFjT06YGd7KzgxRCMnIYbndA1yjMCG6mxI4DWbOBqBVrBZ0H8MM oVEFmfdQwaTl7fs6c53c3vyCePzQVjUWTGQTU+9ja3nULRol8HXT7R/sikwrsow== X-Received: by 2002:a05:6512:3da3:b0:539:8b02:8f1d with SMTP id 2adb3069b0e04-539e551635bmr2803362e87.30.1728895641634; Mon, 14 Oct 2024 01:47:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNGzizcYSea0we+7mFRqxFtVg7tJgmmDdbFHqE+mDRdFYzekLDQxwTxv+nzZLoG0jBJLv5ag== X-Received: by 2002:a05:6512:3da3:b0:539:8b02:8f1d with SMTP id 2adb3069b0e04-539e551635bmr2803341e87.30.1728895641192; Mon, 14 Oct 2024 01:47:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:c:37e0:ced3:55bd:f454:e722? ([2a01:e0a:c:37e0:ced3:55bd:f454:e722]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6d0217sm10791478f8f.60.2024.10.14.01.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 01:47:20 -0700 (PDT) Message-ID: <08d47408-e15d-448f-9fa6-41a3d2ec953f@redhat.com> Date: Mon, 14 Oct 2024 10:47:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] drm/panic: correctly indent continuation of line in list item To: =?UTF-8?Q?Thomas_B=C3=B6hler?= , Miguel Ojeda , Alex Gaynor Cc: Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , rust-for-linux@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20241012075312.16342-1-witcher@wiredspace.de> <20241012075312.16342-5-witcher@wiredspace.de> Content-Language: en-US, fr From: Jocelyn Falempe In-Reply-To: <20241012075312.16342-5-witcher@wiredspace.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/10/2024 09:52, Thomas Böhler wrote: > It is common practice in Rust to indent the next line the same amount of > space as the previous one if both belong to the same list item. Clippy > checks for this with the lint `doc_lazy_continuation`. > > error: doc list item without indentation > --> drivers/gpu/drm/drm_panic_qr.rs:979:5 > | > 979 | /// conversion to numeric segments. > | ^ > | > = help: if this is supposed to be its own paragraph, add a blank line > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation > = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]` > help: indent this line > | > 979 | /// conversion to numeric segments. > | ++ > > Indent the offending line by 2 more spaces to remove this Clippy error. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe > > Reported-by: Miguel Ojeda > Closes: https://github.com/Rust-for-Linux/linux/issues/1123 > Signed-off-by: Thomas Böhler > --- > drivers/gpu/drm/drm_panic_qr.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs > index 5b2386a515fa..58c46f366f76 100644 > --- a/drivers/gpu/drm/drm_panic_qr.rs > +++ b/drivers/gpu/drm/drm_panic_qr.rs > @@ -976,7 +976,7 @@ fn draw_all(&mut self, data: impl Iterator) { > /// * `url_len`: Length of the URL. > /// > /// * If `url_len` > 0, remove the 2 segments header/length and also count the > -/// conversion to numeric segments. > +/// conversion to numeric segments. > /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment. > #[no_mangle] > pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize {