The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Mircea Caprioru <mircea.caprioru@analog.com>,
	Peter Rosin <peda@axentia.se>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mux: adgs1408: fix Wvoid-pointer-to-enum-cast warning
Date: Fri, 02 May 2025 08:40:52 +0100	[thread overview]
Message-ID: <08e6b769888a11bcf9b3faa45d97b1a16a413a0b.camel@gmail.com> (raw)
In-Reply-To: <20250501181819.164207-2-krzysztof.kozlowski@linaro.org>

On Thu, 2025-05-01 at 20:18 +0200, Krzysztof Kozlowski wrote:
> 'chip_id' is an enum, thus cast of pointer on 64-bit compile test with
> W=1 causes:
> 
>   adgs1408.c:63:12: error: cast to smaller integer type 'enum
> adgs1408_chip_id' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> Changes in v2:
> 1. Use kernel_ulong_t instead of uintptr_t
> 2. Rebase
> 
> Patch from 2023:
> Link:
> https://lore.kernel.org/r/20230810095822.123181-1-krzysztof.kozlowski@linaro.org
> ---
>  drivers/mux/adgs1408.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 5386cfedcb06..5eaf07d09ac9 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -59,7 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
>  	s32 idle_state;
>  	int ret;
>  
> -	chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
> +	chip_id = (kernel_ulong_t)spi_get_device_match_data(spi);
>  
>  	mux_chip = devm_mux_chip_alloc(dev, 1, 0);
>  	if (IS_ERR(mux_chip))

  reply	other threads:[~2025-05-02  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-01 18:18 [PATCH v2] mux: adgs1408: fix Wvoid-pointer-to-enum-cast warning Krzysztof Kozlowski
2025-05-02  7:40 ` Nuno Sá [this message]
2025-05-08 15:13 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08e6b769888a11bcf9b3faa45d97b1a16a413a0b.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mircea.caprioru@analog.com \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox