From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Klimov <alexey.klimov@linaro.org>,
lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, sboyd@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, srini@kernel.org,
krzysztof.kozlowski@linaro.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for audio blocks
Date: Fri, 17 Oct 2025 09:43:43 +0200 [thread overview]
Message-ID: <08f52331-baa1-45ef-bfb8-dc6db000ceff@kernel.org> (raw)
In-Reply-To: <DDKE88TY46WS.1XKHP5I1S3CF6@linaro.org>
On 17/10/2025 08:45, Alexey Klimov wrote:
> On Fri Oct 17, 2025 at 7:25 AM BST, Krzysztof Kozlowski wrote:
>> On 17/10/2025 08:13, Alexey Klimov wrote:
>>> If/when pm4125 audio codec will be added to a device tree file, then dtbs
>>> check will emit messages that pmic audio-codec@f000 doesn't match any
>>> of the regexes: '^pinctrl-[0-9]+$'.
>>
>>
>> Future errors because of present mistakes are not a reason to do
>> something. This makes no sense because there is no DTBs with that
>> compatible, so drop this sentence. We never document compatibles,
>> because in the future they will be errors (if I get it right?).
>
> Ok. I can hold it off till it will be started to be used then.
No, you don't get the point. You invented fake (future) error as
rationale... and want to wait till there is real error to commit this?
This makes no sense.
You need to provide rationale for this patch - look at every other commit.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-10-17 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:13 [PATCH v5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for audio blocks Alexey Klimov
2025-10-17 6:25 ` Krzysztof Kozlowski
2025-10-17 6:45 ` Alexey Klimov
2025-10-17 7:43 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08f52331-baa1-45ef-bfb8-dc6db000ceff@kernel.org \
--to=krzk@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox