public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Cc: perex@suse.cz, tiwai@suse.de
Subject: [patch 2.6.14-rc2 3/3] alsa: fix HD audio ALC882 lfe (un)mute
Date: Wed, 28 Sep 2005 17:50:53 -0400	[thread overview]
Message-ID: <09282005175053.11066@bilbo.tuxdriver.com> (raw)
In-Reply-To: <09282005175053.11001@bilbo.tuxdriver.com>

Mark the ALC880 "LFE Playback Switch" as an input, like the other
playback switch settings.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
This is speculative, based on the datasheet and my experience with the
ALC260. I do not have the actual hardware to test this myself. Testing
by others is requested, but I am pretty sure this is correct.

 sound/pci/hda/patch_realtek.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2501,7 +2501,7 @@ static snd_kcontrol_new_t alc882_base_mi
 	HDA_CODEC_VOLUME_MONO("Center Playback Volume", 0x0e, 1, 0x0, HDA_OUTPUT),
 	HDA_CODEC_VOLUME_MONO("LFE Playback Volume", 0x0e, 2, 0x0, HDA_OUTPUT),
 	ALC_BIND_MUTE_MONO("Center Playback Switch", 0x0e, 1, 2, HDA_INPUT),
-	ALC_BIND_MUTE_MONO("LFE Playback Switch", 0x0e, 2, 2, HDA_OUTPUT),
+	ALC_BIND_MUTE_MONO("LFE Playback Switch", 0x0e, 2, 2, HDA_INPUT),
 	HDA_CODEC_VOLUME("Side Playback Volume", 0x0f, 0x0, HDA_OUTPUT),
 	ALC_BIND_MUTE("Side Playback Switch", 0x0f, 2, HDA_INPUT),
 	HDA_CODEC_MUTE("Headphone Playback Switch", 0x1b, 0x0, HDA_OUTPUT),

  reply	other threads:[~2005-09-28 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28 21:50 [patch 2.6.14-rc2 0/3] HD audio realtek codec fixes John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 1/3] alsa: fix HD audio ALC260 mono (un)mute John W. Linville
2005-09-28 21:50   ` [patch 2.6.14-rc2 2/3] alsa: fix alc880_test_mixer typo John W. Linville
2005-09-28 21:50     ` John W. Linville [this message]
2005-09-29 12:25 ` [patch 2.6.14-rc2 0/3] HD audio realtek codec fixes Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09282005175053.11066@bilbo.tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox