Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems

Tinghan Shen
2022-03-30T07:33:39Z

Hi Matthias,

On Tue, 2022-03-29 at 16:27 +0200, Matthias Brugger wrote:
>
> On 29/03/2022 13:45, Tinghan Shen wrote:
> > Add optional host top register base for the reg binding description.
> >
>
> Is this based a on a new version of the IP? Shall we make the second reg
> mandatory for the new HW? If I remember correctly the reg needs to be restored
> after power save event. So I suppose mmc won't work if that's not done. So
> optional wouldn't be the right approach.
>
> Can you please clarify if that's the case.

Yes. This change is introduced since mt8183, and the host top register
is required for mt8183.

We'll try to describe this change clearly in bindings in next version.

Best regards,
Tinghan

>
> Thanks,
> Matthias
>
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 7032f7adf3ca..6d41bcec900f 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,8 @@ properties:
> > - const: mediatek,mt8183-mmc
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> >