From: Greg Ungerer <gerg@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: coldfire: select legacy gpiolib interface for mcfqspi
Date: Wed, 29 Apr 2026 23:45:02 +1000 [thread overview]
Message-ID: <096acd5f-5284-45a4-b634-08514ae8fff1@kernel.org> (raw)
In-Reply-To: <20260428155729.3278685-1-arnd@kernel.org>
Hi Arnd,
On 29/4/26 01:57, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The common coldfire code uses the old GPIO number based interfaces for
> at least the QSPI chipselect lines. Select the required Kconfig symbol
> to keep it building when that becomes optional.
>
> Apparently there are no devices attached to a QSPI controller in any of
> the coldfire boards, so this is not actually used in upstream kernels.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied to m68knommu for-next branch.
Regards
Greg
> ---
> arch/m68k/Kconfig.cpu | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
> index c9a7e602d8a4..148f8a79d206 100644
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -30,6 +30,7 @@ config COLDFIRE
> select CPU_HAS_NO_MULDIV64
> select GENERIC_CSUM
> select GPIOLIB
> + select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
> select HAVE_LEGACY_CLK
> select HAVE_PAGE_SIZE_8KB if !MMU
>
prev parent reply other threads:[~2026-04-29 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 15:57 [PATCH] m68k: coldfire: select legacy gpiolib interface for mcfqspi Arnd Bergmann
2026-04-28 16:06 ` Geert Uytterhoeven
2026-04-29 13:45 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=096acd5f-5284-45a4-b634-08514ae8fff1@kernel.org \
--to=gerg@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox