From: "Maxime Ripard" <mripard@kernel.org>
To: "David Gow" <davidgow@google.com>
Cc: dlatypov@google.com, kunit-dev@googlegroups.com,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
"Benjamin Berg" <benjamin.berg@intel.com>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"Kees Cook" <keescook@chromium.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Rae Moar" <rmoar@google.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Tom Rix" <trix@redhat.com>
Subject: Re: [PATCH v2 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER
Date: Tue, 28 Nov 2023 14:53:37 +0000 [thread overview]
Message-ID: <0977ffcd30973d0edc1ae4132216b094.mripard@kernel.org> (raw)
In-Reply-To: <20231128072410.952662-3-davidgow@google.com>
On Tue, 28 Nov 2023 15:24:07 +0800, David Gow wrote:
> In order to pass functions to kunit_add_action(), they need to be of the
> kunit_action_t type. While casting the function pointer can work, it
> will break control-flow integrity.
>
> vc4_mock already defines such a wrapper for drm_dev_unregister(), but it
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
prev parent reply other threads:[~2023-11-28 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 7:24 [PATCH v2 1/3] kunit: Add a macro to wrap a deferred action function David Gow
2023-11-28 7:24 ` [PATCH v2 2/3] drm/tests: Use KUNIT_DEFINE_ACTION_WRAPPER() David Gow
2023-11-28 7:24 ` [PATCH v2 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER David Gow
2023-11-28 14:53 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0977ffcd30973d0edc1ae4132216b094.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=benjamin.berg@intel.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rf@opensource.cirrus.com \
--cc=rmoar@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox