From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E22E372EED for ; Wed, 29 Apr 2026 22:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777502128; cv=none; b=iB1G/oJS8pfFN1gGcIaMqOJW9uNU9q711sz+6JJxZJN4X20G8HmVqdPP8qHD32C+UAtQlmCwCnWeNwoXjmep4Ol5Z5HxfApaFyrPGyTCiuaFgDz662HHY6CFkM8seMkMnUFDOMBG/SMojj6hjkksT/RcvpJrszPKgsWJ+vcdHak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777502128; c=relaxed/simple; bh=2tDPKTjbFdZ4IlqqnQW5DkIp6V2EH8xoXznFU+LYPPg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L9Pq3cNG4NIDQ0+nQrtuulIlowPCqpkO1xJTEMyNuOPIqH/GNOYTq/0OGtVZLeEODJuITQvjcxNhbqJsUxto7CcEzQMxvHBpxhNqRhYndFoNbzVbsqCx4m9T2Poo9IF0u+8+HSOpIn2W5WQ1+LsalslJyU3bHhtUnP26jbXhx0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UnneAe2k; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UnneAe2k" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35da2d35eccso155457a91.0 for ; Wed, 29 Apr 2026 15:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777502126; x=1778106926; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+QdR822Oh+h/wb6tFT1ZtMo5BW1zB1OWiICj47LJjjk=; b=UnneAe2kAXNFX1jkzz+AhOO60s7haEdI/8oYOXzcDJbFPaal0A05Ud0RuxxMns2mAZ 4ohWhrwbwhsvcdEWuqPj/kmvJd/geh/pqd4DlK5bGGEzMdGGm56CPrU4XMk4nMPkyF+G kLcujeWj+jZCilErec7tyD8mGF4GoSgLtTzjLRpWKcio7Q2lblN/CGSpLgZOZlTWjnWs U6MkvzWcywn+aySj0+J4mio4gXW6BIrVDKLegWUP7I/F3uTrqO0wPgiRSk+0P98RE+zn vOxi6vAOFhRxXZ0Tv5vfiOsCN9dc5urj5Hjga1UXJnZ55Ql1BP6sVkgFvQdHlPLB+wbN Obdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777502126; x=1778106926; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+QdR822Oh+h/wb6tFT1ZtMo5BW1zB1OWiICj47LJjjk=; b=j9iFw8qRuWKddc4OdmD8ReASMEFPsMxaHY0pamrMm7QRe5+xdDKgRMkbqXgDj3jGJK 6cBVG40+P6pFl565X76Z8ibYKi1Xkm9RF8vwxPbOg17I7XplVxxZqDICsc2/dAYNauoA YKUBehaYSC3M8dAOfvJdLPCI54g5kXh4pLxjlr1Tm71y41wcdkRsJ05vjR1aRViMFcr6 vQdBzYDx5vSWjiB5iR5bhJ1YiXbDc1b7KpfTX8TfgCBjtU6INdhEmyDLvpo1vSTRjFPX uCaXPpAOg2N9mQQbsVShViC8ZKTt/Qx0n1n/D/Vg6wVRKQZwaRNsjRGNgwe+nJfpJFmT gmzA== X-Forwarded-Encrypted: i=1; AFNElJ/QfsnRp/AYRjF0sClIQyy9E484qIRE+nyV7DN2KY1e0UGTMbiZCRgzJ+Z+gaL+ee0Pt7njk6VbpDB1NAM=@vger.kernel.org X-Gm-Message-State: AOJu0YxBUAMF+LHFFFtjekuuZE9hUhnf2v5RwlDG/7YQpqZbt8uj1EnN IPWSc2zcWXYGNF8D739GGqhukYH+36xx2h7nq/g74ITBYOrKiMwWWEn6 X-Gm-Gg: AeBDieuAbRpPXkQp8lxWYuQPzJyrvqU9XtD54+vqHMfy0+8ccBEAC/Q0THUUXliERKC 0VqKcAkJKIZEn/42FkdCtq+NwtbYoBronQSyiZ9jWCh6dL4bnq/v1yuWlroX3pw74dCEkGD+4aa BS6QhIFiR8JA9A9rEaohHxH//efZWxgrVXOsZpdfObg/v/K/Lq/bjRJucv5AACR3zARk19GL5iX uG2G3K28SAB2i+a/WMI+UW/Li1Rf5CGjR+pP2tuYTjmgKJPfeB3AVqC9KiytvbOwp6W/TsfogKY 6aFnXWmU6zwaRv3SvzId9T6PXGQ2kkb8sz5C/AXSVDNUflh3xAZWbrALEuB8M/aROytd8MNp4cy tXIkxkm/5735DuTLtdRKQ9wQgsGJU1HwYmnJLitfAibBoRQg66CiW/tLKftR0kj3iA2t5/aDmO6 6BoQrGUG8KgsrRYiwjXMW3N9jPRGFfxf7IO2YQ+MBd4vReNZqSHQ== X-Received: by 2002:a17:90b:3505:b0:35b:e690:c5ad with SMTP id 98e67ed59e1d1-364c310b735mr183471a91.25.1777502126475; Wed, 29 Apr 2026 15:35:26 -0700 (PDT) Received: from [172.30.1.27] ([222.106.243.217]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364bdf69bc2sm649418a91.10.2026.04.29.15.35.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 15:35:25 -0700 (PDT) Message-ID: <097b96b4-9a43-404d-b06e-9b087a37dec4@gmail.com> Date: Thu, 30 Apr 2026 07:35:22 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] devfreq: event: rockchip-dfi: fix missing clk_disable_unprepare() on error Content-Language: ko To: Anas Iqbal , Chanwoo Choi , MyungJoo Ham , Heiko Stuebner Cc: Kyungmin Park , Sascha Hauer , Sebastian Reichel , Jonathan Cameron , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260319163011.18876-1-mohd.abd.6602@gmail.com> From: Choi Chanwoo In-Reply-To: <20260319163011.18876-1-mohd.abd.6602@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 2026-03-20 AM 1:30에 Anas Iqbal 이(가) 쓴 글: > Smatch reports: > drivers/devfreq/event/rockchip-dfi.c:215 rockchip_dfi_enable() warn: > 'dfi->clk' from clk_prepare_enable() not released. > > If rockchip_dfi_ddrtype_to_ctrl() fails after clk_prepare_enable(), > the clock is not disabled, leading to a resource leak. > > Add clk_disable_unprepare() in the error path to properly release > the clock. > > Fixes: d724f4a4581b ("PM / devfreq: rockchip-dfi: Prepare for multiple users") > Signed-off-by: Anas Iqbal > --- > drivers/devfreq/event/rockchip-dfi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 5e6e7e900bda..8db0bceeded4 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -185,8 +185,10 @@ static int rockchip_dfi_enable(struct rockchip_dfi *dfi) > } > > ret = rockchip_dfi_ddrtype_to_ctrl(dfi, &ctrl); > - if (ret) > + if (ret) { > + clk_disable_unprepare(dfi->clk); > goto out; > + } > > for (i = 0; i < dfi->max_channels; i++) { > Applied it. Thanks, Chanwoo Choi