From: Dave Hansen <dave.hansen@intel.com>
To: Maksim Davydov <davydov-max@yandex-team.ru>
Cc: den-plotnikov@yandex-team.ru, tony.luck@intel.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, x86@kernel.org
Subject: Re: [PATCH] x86/split_lock: add split lock counter
Date: Tue, 2 Jan 2024 07:14:10 -0800 [thread overview]
Message-ID: <098a3e0a-eb84-4604-95a8-8b4e8a2e7a4b@intel.com> (raw)
In-Reply-To: <039b8ba2-09c8-487d-b2ef-f74d6ab4e489@yandex-team.ru>
On 12/16/23 02:56, Maksim Davydov wrote:
> On 12/15/23 21:16, Dave Hansen wrote:
>> On 12/15/23 06:01, Maksim Davydov wrote:
>>> Provides per task split locks counter to monitor split locks rate
>>> in the system. It can be helpful in split locks monitoring to get a
>>> clear
>>> sense of which process causing split locks and how many of them have
>>> happened by the moment. For instance, it might be used by cloud
>>> providers
>>> who can't control guest executable code and want to make decisions based
>>> on the rate value like ratelimiting or notifing the split lock origins.
>> Have you considered doing this with tracing instead?
>>
>> It seems a _little_ silly for everyone to pay the cost of having that
>> counter around.
> No, it just seemed like a good idea to make a simple machine-readable
> interface based on the existing flag (reported_split_lock).
> What if this interface is made together with the appropriate CONFIG flag
> (default false)? Thus it won't affect those who don't need it.
Distributions (effectively) run a single kernel config. They turn on
almost everything. Using a config option would subject all distro users
to the overhead.
next prev parent reply other threads:[~2024-01-02 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 14:01 [PATCH] x86/split_lock: add split lock counter Maksim Davydov
2023-12-15 18:16 ` Dave Hansen
2023-12-16 10:56 ` Maksim Davydov
2024-01-02 15:14 ` Dave Hansen [this message]
2023-12-16 2:21 ` kernel test robot
2023-12-16 3:27 ` kernel test robot
2023-12-16 5:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098a3e0a-eb84-4604-95a8-8b4e8a2e7a4b@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davydov-max@yandex-team.ru \
--cc=den-plotnikov@yandex-team.ru \
--cc=hpa@zytor.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox