From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0465DC433EF for ; Tue, 5 Jul 2022 18:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231414AbiGESB0 (ORCPT ); Tue, 5 Jul 2022 14:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231441AbiGESBY (ORCPT ); Tue, 5 Jul 2022 14:01:24 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 942F71EAD9 for ; Tue, 5 Jul 2022 11:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657044083; x=1688580083; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jWFMuzOwTF/I32i1P2X0zjw0ibfU/WeavbtARFtZfEg=; b=E5Jil+W/tVMfZNcwous6PWiqvk/EfuYrZAOYhypdl1YAD3AD/FFVD8FW 9kWe50XVeXzui2VaDRUeKA/R0TDpN3sc4IeBn3rbswATGYTBzEEkieiQs rjepITWWQZG5oG2SywUvYxHZt6ZPprow52U8d2jSthyxJcXFn9dcxjYJt U4XrgtYq0pcXDKKcVC7JFtGfzkxwWX3bprSoYLQEknr7f/iIvAodv24Ji ANiYo1MODS7DdQ+LzKE/+aqWq1JQkedwQWjVG39JZAL3LVX8f76fUDW1F S2V35C451W9N8kLV0Z6cxihFvpEXu5ZbpbZTmaVwwfO06qB9UB3YKL9aF w==; X-IronPort-AV: E=McAfee;i="6400,9594,10399"; a="282184029" X-IronPort-AV: E=Sophos;i="5.92,247,1650956400"; d="scan'208";a="282184029" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 10:53:53 -0700 X-IronPort-AV: E=Sophos;i="5.92,247,1650956400"; d="scan'208";a="682608821" Received: from wxu3-mobl1.amr.corp.intel.com (HELO [10.212.54.191]) ([10.212.54.191]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 10:53:52 -0700 Message-ID: <09a7734c-dc79-21a1-1b24-9639f2a17e58@linux.intel.com> Date: Tue, 5 Jul 2022 11:57:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: [PATCH v2 1/2] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval Content-Language: en-US To: Andy Shevchenko , Mark Brown , Peter Ujfalusi , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Kai Vehmanen , Bard Liao , Takashi Iwai , Liam Girdwood , Ranjani Sridharan , Daniel Baluta References: <20220705161102.76250-1-andriy.shevchenko@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <20220705161102.76250-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/5/22 11:11, Andy Shevchenko wrote: > device_get_match_data() in ACPI case calls similar to acpi_match_device(). > Hence there is no need to duplicate the call. Just assign what is in > the id->driver_data. > > Signed-off-by: Andy Shevchenko Acked-by: Pierre-Louis Bossart > --- > v2: moved desc assignment closer to its user (Péter) > sound/soc/sof/intel/bdw.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c > index 26df780c702e..a446154f2803 100644 > --- a/sound/soc/sof/intel/bdw.c > +++ b/sound/soc/sof/intel/bdw.c > @@ -681,11 +681,8 @@ static int sof_broadwell_probe(struct platform_device *pdev) > return -ENODEV; > } > > - desc = device_get_match_data(dev); > - if (!desc) > - return -ENODEV; > - > - return sof_acpi_probe(pdev, device_get_match_data(dev)); > + desc = (const struct sof_dev_desc *)id->driver_data; > + return sof_acpi_probe(pdev, desc); > } > > /* acpi_driver definition */