Re: [PATCH v2 0/4] wifi: mwifiex: drop asynchronous init waiting code

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2025-04-23 at 10:21 +0200, Sascha Hauer wrote:
> This is a spin-off from my mwifiex cleanup series. I have split the
> original single patch into a series which hopefully makes the changes
> easier to follow and verify.
> 

I'm applying this, but I removed a now unused variable in the first
patch that you only removed in the third. I guess that comment might've
gone into the wrong patch too.

Please, everyone, especially when resubmitting look at patchwork first,
there's a reason I put the bot there :)


In this case the issue was already in v1:

https://patchwork.kernel.org/project/linux-wireless/patch/20250410-mwifiex-drop-asynchronous-init-v1-1-6a212fa9185e@pengutronix.de/

->
http://wifibot.sipsolutions.net/results/951965/14046284/build_clang/summary

[...]
New errors added
--- /tmp/tmp.KVymmMae73	2025-04-10 15:54:35.187566833 +0300
+++ /tmp/tmp.xeV1sgB9ae	2025-04-10 15:54:51.973439711 +0300
@@ -17,0 +18,4 @@
+../drivers/net/wireless/marvell/mwifiex/init.c:490:6: warning: unused variable 'is_cmd_pend_q_empty' [-Wunused-variable]
+  490 |         int is_cmd_pend_q_empty;
+      |             ^~~~~~~~~~~~~~~~~~~
+1 warning generated.
Per-file breakdown
--- /tmp/tmp.LJz16ltpSv	2025-04-10 15:54:51.980439658 +0300
+++ /tmp/tmp.5qRbEVE9cC	2025-04-10 15:54:51.983439635 +0300
@@ -0,0 +1 @@
+      1 ../drivers/net/wireless/marvell/mwifiex/init.c

johannes