Re: [PATCH 06/13] ASoC: tegra: Add Tegra210 based MVC driver

Mark Brown
2021-09-13T14:52:46Z

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On Mon, Sep 13, 2021 at 10:32:32AM +0530, Sameer Pujar wrote:
> On 9/3/2021 11:43 PM, Mark Brown wrote:

> > > + err |= regmap_update_bits(mvc->regmap, TEGRA210_MVC_SWITCH,
> > > + TEGRA210_MVC_VOLUME_SWITCH_MASK,
> > > + TEGRA210_MVC_VOLUME_SWITCH_TRIGGER);
> > > +
> > > +end:
> > > + pm_runtime_put(cmpnt->dev);
> > > + return err;
> > > +}

> > _put() should return 0 if there's no change or 1 for a change.

> So this means, no need to return any error value and just return 0 in such
> cases?

If there's an error you should return that instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]