From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D7A638F232 for ; Thu, 2 Apr 2026 13:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775135199; cv=none; b=LK3xoCAH2dsplR94+xEL2yctMDYlsgtD0wTV6igV0lnaAGrQ7M8+QvkFZ2QO7Y+YIXUfj2JoRiUv9eu+Xh41c4PPckK3NBY9Yt/dHnqT2EEyI7LxZYRKibWNu/l1rjxDynLosuMzzgdvn2QpH67/zMRUYaPRcmlTTuxIL/45pEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775135199; c=relaxed/simple; bh=fLISTcpkq3vlQbd3myrhqO+dyl+JVGQYoiohUrWpfMI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g/AYGmcNg2FedVJnFKI+fh8DALls5w1wYzUTv+YmfyJSsH60kruqEyJP2b89fpkr6AmVwQVyVD8I2IODZOaOnNvG9505WhIbfrngvtfRm11KrcbSmEp7IvKCCO0zfrlSdQBU50sgvxk9vv2aJbK3yw/6jDG2LmotwP2c0PKSQwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=axssw0zo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BO9DE3m3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="axssw0zo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BO9DE3m3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775135192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ZfYOudIChwa/S+tLKsP2bUZS1mOOgqBWmRnN94V3MM=; b=axssw0zofd6L7EZLhFMT95cLA06DMDrzXu9k8s35jxRpIaypRujipN7jY+sobCDD3dWBFH Ct/OHMEvtp3Ani78sRmO9Kgu6f5c9NLzizTAbrlv4aRolvlK96UnZU8ZsB42QBoFVtqar7 686+d/cpy8pr8Yg0Hm02hJ3NVPKhpk0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-SWwjTx5PMiy847q7RXotGA-1; Thu, 02 Apr 2026 09:06:30 -0400 X-MC-Unique: SWwjTx5PMiy847q7RXotGA-1 X-Mimecast-MFC-AGG-ID: SWwjTx5PMiy847q7RXotGA_1775135189 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-486fe36cf73so5792675e9.1 for ; Thu, 02 Apr 2026 06:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775135189; x=1775739989; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8ZfYOudIChwa/S+tLKsP2bUZS1mOOgqBWmRnN94V3MM=; b=BO9DE3m3rGbOkzMWrLE3k1pSA1i8/UA4q02JgUJ8T5aZQTIUumwyvAa2cTGiHpi7IC Uvue0usgIBlgqdS9Nv2KyWT5WBjba8oKrrZk6vegWIhCW+g6hwWRp6icR532l2CJOMFP tbGYTJIoHRum9QXvCwH58NCq5S1JfA3ZtgUXspBeVgtXtk70sWcBW2/rk+NYINfgBPlH YEwt6CauWm12qij3ZuEgXu9vy/rypkuGRvzj4zl0DBt0u5wx3uiI+m/ze+WmiP45PBRw 1whCOQI4AnL8TnoJuwrq9I1lwiJ8cyOvyJFoIaObNMunsz9BadLXsEPZlu95UYRllmLO mFeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775135189; x=1775739989; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ZfYOudIChwa/S+tLKsP2bUZS1mOOgqBWmRnN94V3MM=; b=NQUZqv2c+8jDUIiOKOWA65O+39v9wQVz9u+rOk3QTQ0IfTo0ZlU/MTZEWJqSDL0Vh+ 7vBjOa/4pEVGCTJRLPY2iCwo2Xumd2ehjXTO+1ryZv9WutfOo05nuQu5sr//cWXO8Jt7 +9Vd1C/XzNLxScBwxXDYD6ty9ZoPUavInVNiftHqf+Bv+qm8XXW/Zsx2eYMux+YtdRn7 aDeRGa2CoTBe4gSY8dixtCOIJgCuqLecZsygwjXTlrYr+qLe6Mh7l3tGraHlVScnSDPj O9IqF+FCL79AuBOutTHEXYThT1CDl98pgdTSpwm85EqCWKXFkuFVpWF3dQj2OxV60ZX+ XkfA== X-Forwarded-Encrypted: i=1; AJvYcCU3POh75pJcKkEfHZZhrfsBMguWNseRX4xyvcUQGQ1gElufq++99ftz3sBtmQATodeXW3+XGpj1GnP/HEw=@vger.kernel.org X-Gm-Message-State: AOJu0YznWyHSvIA6EJH7wSGmIc3pnllPseppnWAmYhWIv1lTO/pyXrDA 4zJaVsVHTmCf9yUGfzOU8WiQQ594KwF7bZya9su2BmEOx+0szlqC4OtCpn822ScufctCbjwQMEt whX8ILj2Rk1zh9rQ0RRKGrn93E4kubOUSZjms7kV+6Nm1vtHoAfmhYB5CpJZO/VqiBQ== X-Gm-Gg: ATEYQzyn/gbrJmsn3rFuQTD+wB9Svglb6kQRuIk8KAmkIaTrVSqyyqW7KmyaYo3VkfD 7WgsfSt1GHhKCpsw5lcbeE8gl+8NE6RmQpQ3lYhEafehKFMgzIXF/JMn6opKe43TVFfMEt1rFCU mYKLVE3QzNblu+sTw1aLcLUiRxADZCQgJ23nu54ZSTQm5BeCmVVH+sV1DC3uQm1IUXiPuhH7v/u HuuEL6A5qkX00Cw0AWECtopj8/qtl3Lf+BC2KunudnGLJVTW5HpY7LUtTA1gsexkRqEMxRf/S2E MB0y2uVMAMsSAhvZBE4tDzPMIDCvH9dBIt4z5Hf6nyNd+rGby+kkfjy8ZvAYkPa1nFVso5G1i01 rXWupuTsRFtN8m5+gZCO0vfAbulOsvuTbIgevzBPzzfYtC6rrP1G8jT52rg== X-Received: by 2002:a05:600c:3508:b0:488:95d0:ee46 with SMTP id 5b1f17b1804b1-48895d0ef40mr7906375e9.19.1775135189419; Thu, 02 Apr 2026 06:06:29 -0700 (PDT) X-Received: by 2002:a05:600c:3508:b0:488:95d0:ee46 with SMTP id 5b1f17b1804b1-48895d0ef40mr7905695e9.19.1775135188911; Thu, 02 Apr 2026 06:06:28 -0700 (PDT) Received: from [192.168.88.32] ([212.105.153.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f5016sm8306210f8f.33.2026.04.02.06.06.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 06:06:28 -0700 (PDT) Message-ID: <09e99e68-f7b1-415d-b1ed-efe632432222@redhat.com> Date: Thu, 2 Apr 2026 15:06:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 12/13] net: renesas: rswitch: add handler for FDB notification To: Michael Dege , Yoshihiro Shimoda , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Paul Barker Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260331-rswitch_add_vlans-v3-0-c37f41b1c556@renesas.com> <20260331-rswitch_add_vlans-v3-12-c37f41b1c556@renesas.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260331-rswitch_add_vlans-v3-12-c37f41b1c556@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/31/26 12:04 PM, Michael Dege wrote: > +/* called under rcu_read_lock() */ > +static int rswitch_switchdev_event(struct notifier_block *nb, > + unsigned long event, > + void *ptr) > +{ > + struct net_device *ndev = switchdev_notifier_info_to_dev(ptr); > + struct rswitch_switchdev_event_work *switchdev_work; > + struct switchdev_notifier_fdb_info *fdb_info; > + struct switchdev_notifier_info *info = ptr; > + struct rswitch_private *priv; > + int err; > + > + priv = container_of(nb, struct rswitch_private, rswitch_switchdev_nb); > + > + switch (event) { > + case SWITCHDEV_FDB_ADD_TO_DEVICE: > + fallthrough; > + case SWITCHDEV_FDB_DEL_TO_DEVICE: > + switchdev_work = kzalloc(sizeof(*switchdev_work), GFP_ATOMIC); > + > + if (!switchdev_work) > + return NOTIFY_BAD; > + > + switchdev_work->ndev = info->dev; > + switchdev_work->priv = priv; > + switchdev_work->event = event; > + > + fdb_info = container_of(info, > + struct switchdev_notifier_fdb_info, > + info); > + > + INIT_WORK(&switchdev_work->work, rswitch_switchdev_bridge_fdb_event_work); > + > + memcpy(&switchdev_work->fdb_info, ptr, sizeof(switchdev_work->fdb_info)); > + > + switchdev_work->fdb_info.addr = kzalloc(ETH_ALEN, GFP_ATOMIC); > + if (!switchdev_work->fdb_info.addr) > + goto err_addr_alloc; > + > + ether_addr_copy((u8 *)switchdev_work->fdb_info.addr, > + fdb_info->addr); > + dev_hold(ndev); Please switch to netdev_hold()/netdev_put(), providing a suitable netdevice_tracker. /P