From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577553947AE for ; Mon, 8 Jun 2026 08:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907021; cv=none; b=rwPNTjnCtf2l8Jiku3yZ2MfRH3crue75r04g06HBbd2LR2CZrc/p+sIlfm5kvpMCsSsAJC6PQJy9UTC6mUzfxYgVd/5bEfZM/1dU/7+pZwGRVn97ClM6imx/4O0kgxN7A91ot6tmbVdvLOGmCxUxdhcJsGUcjNXZfMNmx92ZL1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907021; c=relaxed/simple; bh=Dd4rcMrv51UewjxgT22w+WOnqGrV5cgFZoBCGY1q2O0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YRbaa+r58tEiptm92j6TLwC0H92EFOaqu7MR822ThT5IfD/0Cq41YXdaApO2xQ6E90SOosB99kyZbVRwOn9R2ny4yjrARFmMH+UylHtdeusMQWCD98OqBTdkjLO/gEzHgM+EGycPZ2tGUphN+t+wWriUmdrib8RxunWMHlShxkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NgsY1gpQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AjhzgKkq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NgsY1gpQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AjhzgKkq" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586Ot552384520 for ; Mon, 8 Jun 2026 08:23:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XlNdEziaoTE5V4DLXUj13oxUgJxGoijkLhriRZb5DmM=; b=NgsY1gpQY8Go+fQr udoCiCWo173yMkUfA/ze1akq2DypD1PTRuTtJyFTKftjr53fIl0vi23u7DCzm2mj v+A3Y9jBY0YXSHFWOEwG5Gszegsvxi0LMMVOEu/SI+Bx/Lz8QiyiFTjN4CAV3JB5 te8EUMaJ59ryNBLITo7XhtOKd43+P8AGlN75PiSre7PSGR6k/KYGSFevNRHVVSVu 1du8oC+V6KW6rb5vuxNF9gkS3faSSHDHRvM9UfX23cyX603yxLE/cCfg+xpFtYQs jw7+Kobg7+8m4e9myH6XdxjO8Y1Zw6LVG6oxo4DkJqxEHZrU+bGYu6ukWkWgvY0H VgZo1g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embs1enj8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 08:23:38 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-915737aaf0bso114750185a.3 for ; Mon, 08 Jun 2026 01:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780907018; x=1781511818; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XlNdEziaoTE5V4DLXUj13oxUgJxGoijkLhriRZb5DmM=; b=AjhzgKkqC9lcRfWjKrQNiyy6mHzIiYVfQaeF6nakwzfO2EslSqAD7gqBgT5GnrozU/ +urSNRH7OmQ1xtm9tGAxM6oKgI6WOlp/okb1OEp6gvusZkcICibnsw1n7o5vPpI2538q LqWKxcA2NmvTcsMSogWYh2n4M77CaRjE+Vn5AoRmbQZZbCikn0IztJjddhRocJiEtYY1 zX52PTY3NLZdSsERsEspvDOUgsMyHbBT9haZyj7W8oUzdmrzKQHe2MAFYG0ODpGdltKh DFHB3J+aia8iDAsIoqWa0KnLT8H9m9LH6KUcXdX3KI+Y3EUKWE86iz8JL0M5vmgFFNQ3 MqpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780907018; x=1781511818; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XlNdEziaoTE5V4DLXUj13oxUgJxGoijkLhriRZb5DmM=; b=W75E6NxXYGBwGNg7j9UsOxClajfl8JvHBJ996l1WrgKJWdr7AhgvlKTsoXdUNQFxEv uM8b3d8epUVe/dz65zU+AxPXQgd3xxtm56CFL5x46RGEg605fnwxLn0qLtmADW9ZIbfi 48CQ+ByrJH2Sf+3dAkDIA5TS+Lod7YVP1vWdesTHFPLIE2y3DgbMaqydZPYwr/Ob/5qm yXMbp6d+xeOK1l8wPLYMy3LFFfxtHYMCmOLFmA+M+Ssy4P99ubtUptXoDGJXO/+PoMGu E8vljm+43tgg0fUztuqfRijbiC5fOeKFmEKpqx6B3K7mXlD+UpwDFHEolyrPikDpdnnE aPYA== X-Forwarded-Encrypted: i=1; AFNElJ+1iVPsordSRJDOGRYnm3YyMF1QzsVwz9oD4UG+yn93abVfqhTwrlDoQcIKaNpkmCSgNeXuovyKwje9ahk=@vger.kernel.org X-Gm-Message-State: AOJu0YwnnTrzSObWZttpDZs/uTc84qmvYdbl/ke/Mw8xzAy+4ZrJICxv EAvUGZMAUiCDe36YfsC3+RJhk/ckz0YExhYtntngVLeXwLN++F9NqaZ2QKQm0D/ch8mhkCorK3g 90T0GdGewO+1Vo3UnqkxLN2qROSylSNkvt4HoC57MVZYhRWmoy1AUoWlTT5zQTz40eoc= X-Gm-Gg: Acq92OG5ie5HSXZNJy4my+j+9ftwRq5mso6LRxXzzCcd1PwzLtXXVnliujt7ihgsXNO rVuZ/xuSgorndukcBmrqE5C2toNFH4gJbBfZyWT1MqiibhWN1+iYxLbQ1DBpGawpJyKz6zmGVN1 fckKrkXYO8kge+g7ZkN/8L5Bwm15W5oqaV+roR2ORbrKrSDFrNGXNxSXgP5DdbZynb24oB/wR9I yCEL7eXo8RxmXxnkUw6qHco705vohpFNO97JTVaVPA61A5ArWBYdT1tA244YcUVzY7veNwzrXVj GmAdtNlKrvZZtq8fM0nrd6OTW5WaV0gydltWJwdTxEwNKbrwm2bk7icOz6PdjLfGkjGbVUcc0nN C2FlgZ0bUxBr9Y7BEdFgPvUjeyl4oQbKEVdtMTMsnFRH0Fi4myUXak/kT X-Received: by 2002:a05:620a:2681:b0:915:54b2:582d with SMTP id af79cd13be357-915a9e4ddc3mr1371597885a.8.1780907017627; Mon, 08 Jun 2026 01:23:37 -0700 (PDT) X-Received: by 2002:a05:620a:2681:b0:915:54b2:582d with SMTP id af79cd13be357-915a9e4ddc3mr1371595785a.8.1780907017188; Mon, 08 Jun 2026 01:23:37 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf051770994sm839798766b.13.2026.06.08.01.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 01:23:36 -0700 (PDT) Message-ID: <0a14d85b-ce64-4c9f-8cc4-23cd0f963d98@oss.qualcomm.com> Date: Mon, 8 Jun 2026 10:23:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: ps883x: Fix DP+USB3 configuration To: Stephan Gerhold , Heikki Krogerus , Greg Kroah-Hartman Cc: Jack Pham , Abel Vesa , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260601-ps883x-usb3dp-fixes-v1-1-d19bec3a6d26@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260601-ps883x-usb3dp-fixes-v1-1-d19bec3a6d26@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA3NyBTYWx0ZWRfXxD6JBQzjdUFh OV1HHciD1IWW/O2DO/KVhx9nwb2kOa245BDA1c4KpbCICaDzN7kHn/5VmhbPECLjEoMr3SXH61d qr8S3inKhWhKE2d4FLwTraBSerL26ltbG4NB5TM9elwpgj4ibfX9ZmlFWP/g7rUVtgNDAV5Pbua L0+bOng5D2ozVSwXV488CEZ/hUu2/8G2EAT3mV/jQ7htPD3TuSkiaeAT/RCNUXVRwrqg2n+WvX+ chvBi3mQzglg+nn0qGhNvqp/ivvZfY6seBpYVxli7mHmrw6wcrphSFWSgXGbrS36Da357pJVN1J o32IZQtBAeHVowIiVBG93aJ1Jb6AZfojMtmrpdoitCoVVEmxtFNVSOjKQ/5u4HGdnDs5pMyRdod 0Ult3t0PWBO14qQdPXx6lzIiyROfyv9fia3Hcke2MncnPUhEWSn1hjdt5ARBIriltypJ1zO8QJU xsNM0d5ySWpqrH89MtA== X-Authority-Analysis: v=2.4 cv=CeY4Irrl c=1 sm=1 tr=0 ts=6a267c0a cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=hbyEuSSbhPzj9LylT5UA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: wLxXj8hbQsEyvfJ9TmkxNa9SofHOLG8w X-Proofpoint-GUID: wLxXj8hbQsEyvfJ9TmkxNa9SofHOLG8w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080077 On 6/1/26 3:55 PM, Stephan Gerhold wrote: > Commit 6bebd9b77726 ("usb: typec: ps883x: Rework ps883x_set()") introduced > two regressions: > > 1. The CONN_STATUS_0_USB_3_1_CONNECTED bit is mistakenly written to the > wrong configuration register (cfg1 instead of cfg0). This breaks USB3 > when using USB3+DP adapters. > > 2. The switch-case fallthrough block is inverted: Currently, > TYPEC_DP_STATE_C (DP-only) inherits the USB3 configuration, while > TYPEC_DP_STATE_D (DP+USB3) is missing the necessary DP sink flags. > > Fix these by writing the USB3 bit to the correct register and swapping the > case statement order so both states get their correct bits assigned. Oops.. sorry about this.. I only had a 4lndp display to test the DP altmode path.. Reviewed-by: Konrad Dybcio Konrad