From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbaIXQdn (ORCPT ); Wed, 24 Sep 2014 12:33:43 -0400 Received: from mail.kmu-office.ch ([178.209.48.102]:40789 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbaIXQdm (ORCPT ); Wed, 24 Sep 2014 12:33:42 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset= Content-Transfer-Encoding: 7bit Date: Wed, 24 Sep 2014 18:33:03 +0200 From: Stefan Agner To: Linus Walleij Cc: Alexandre Courbot , Russell King - ARM Linux , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer , jingchang.lu@freescale.com, Huang Yongcai-B20788 , Shawn Guo Subject: Re: [PATCH 5/9] gpio: vf610: Extend with wakeup support In-Reply-To: References: <704b6bb97147b3d0ee1557b43d85ab9376c28666.1411404079.git.stefan@agner.ch> Message-ID: <0a182a1652d0271cdd0a262bc9efc945@agner.ch> User-Agent: Roundcube Webmail/1.0.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2014-09-24 11:19, schrieb Linus Walleij: > On Mon, Sep 22, 2014 at 7:09 PM, Stefan Agner wrote: > >> Support Vybrid GPIO's as wakeup source by requesting the parent >> IRQ as wakeup IRQ. >> >> Signed-off-by: Stefan Agner >> --- >> drivers/gpio/gpio-vf610.c | 16 ++++++++++++++++ > > This driver is not yet upstream. Make wakeup support part > of the initial driver submission instead, it doesn't hurt. Ok, will do. Just realized that this patch even leads to compile errors when applying on top of v2 of the GPIO driver; we need the irq in drivers struct here, and I removed that in v2... :-) -- Stefan