RE: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

["Ding, Shenghao" <shenghao-ding@ti.com>]

> -----Original Message-----
> From: Ding, Shenghao <shenghao-ding@ti.com>
> Sent: Wednesday, February 7, 2024 5:48 PM
> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
> broonie@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org;
> robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; linux-
> sound@vger.kernel.org; liam.r.girdwood@intel.com; lgirdwood@gmail.com;
> linux-kernel@vger.kernel.org
> Cc: Lu, Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; P O, Vijeth
> <v-po@ti.com>; Navada Kanyana, Mukund <navada@ti.com>;
> perex@perex.cz; McPherson, Jeff <j-mcpherson@ti.com>; pierre-
> louis.bossart@linux.intel.com; 13916275206@139.com; Chawla, Mohit
> <mohit.chawla@ti.com>; soyer@irl.hu; Huang, Jonathan
> <jkhuang3@ti.com>; tiwai@suse.de; Djuandi, Peter <pdjuandi@ti.com>;
> Agrawal, Manisha <manisha.agrawal@ti.com>; Hari, Raj <s-hari@ti.com>;
> Yashar, Avi <aviel@ti.com>; Nagalla, Hari <hnagalla@ti.com>; Bajjuri,
> Praneeth <praneeth@ti.com>
> Subject: RE: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240:
> Add initial DT binding
> 
> > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof. 
> > kozlowski@ linaro. org> > Sent: Tuesday, February 6, 2024 9: 53 PM >
> > To: Ding, Shenghao <shenghao-ding@ ti. com>; broonie@ kernel. org; >
> > conor+dt@ kernel. org;
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source of
> this email and know the content is safe.
> 
> ZjQcmQRYFpfptBannerEnd
> 
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Sent: Tuesday, February 6, 2024 9:53 PM
> > To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
> > conor+dt@kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org;
> > andriy.shevchenko@linux.intel.com; linux-sound@vger.kernel.org;
> > liam.r.girdwood@intel.com; lgirdwood@gmail.com; linux-
> > kernel@vger.kernel.org
> > Cc: Lu, Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; P O,
> > Vijeth <v-po@ti.com>; Navada Kanyana, Mukund <navada@ti.com>;
> > perex@perex.cz; McPherson, Jeff <j-mcpherson@ti.com>; pierre-
> > louis.bossart@linux.intel.com; 13916275206@139.com; Chawla, Mohit
> > <mohit.chawla@ti.com>; soyer@irl.hu; Huang, Jonathan
> > <jkhuang3@ti.com>; tiwai@suse.de; Djuandi, Peter <pdjuandi@ti.com>;
> > Agrawal, Manisha <manisha.agrawal@ti.com>; Hari, Raj <s-hari@ti.com>;
> > Yashar, Avi <aviel@ti.com>; Nagalla, Hari <hnagalla@ti.com>; Bajjuri,
> > Praneeth <praneeth@ti.com>
> > Subject: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add
> > initial DT binding
> >
> > On 03/02/2024 04: 05, Shenghao Ding wrote: > + > + ti,tad5212:
> > Low-power stereo audio DAC with 120-dB dynamic range. > + oneOf: > + -
> > items: > + -
> > enum: > + - ti,adc3120 > + - ti,adc5120 > + - ti,pcm3120 > + -
> > ti,pcm5120 ZjQcmQRYFpfptBannerStart This message was sent from
> outside
> > of Texas Instruments.
> > Do not click links or open attachments unless you recognize the source
> > of this email and know the content is safe.
> >
> > ZjQcmQRYFpfptBannerEnd
> > On 03/02/2024 04:05, Shenghao Ding wrote:
> > > +
> > > +      ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic range.
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - ti,adc3120
> > > +              - ti,adc5120
> > > +              - ti,pcm3120
> > > +              - ti,pcm5120
> > > +              - ti,pcm6120
> > > +          - const: ti,adc6120
> > > +      - items:
> > > +          - enum:
> > > +              - ti,pcm6260
> > > +              - ti,pcm6140
> > > +              - ti,pcm3140
> > > +              - ti,pcm5140
> > > +          - const: ti,pcm6240
> > > +      - items:
> > > +          - const: ti,dix4192
> > > +          - const: ti,pcm6240
> >
> > Why dix4192 is not part of previous enum?
> 
> dix4192 is not traditional ADC or DAC, but an Integrated Digital Audio
> Interface Receiver and Transmitter, like an audio bridge to connect different
> digital audio protocol, compatible with the AES3, S/PDIF, IEC 60958, and EIAJ
> CP-1201 interface standards, Left-Justified, Right-Justified, and Philips I2S™
> Data Formats.
> So keep it alone for professional purpose.
I will add detail dix4191 description in next patch.
> 
> >
> > > +      - items:
> > > +          - const: ti,adc6120
> > > +          - const: ti,pcmd512x
> > > +      - items:
> > > +          - const: ti,pcm1690
> > > +          - const: ti,pcm9211
> > > +      - items:
> > > +          - enum:
> > > +              - ti,pcmd3180
> > > +          - const: ti,pcmd3140
> > > +      - items:
> > > +          - enum:
> > > +              - ti,taa5412
> > > +          - const: ti,taa5212
> > > +      - items:
> > > +          - enum:
> > > +              - ti,tad5412
> > > +          - const: ti,tad5212
> > > +      - enum:
> > > +          - ti,pcm6240
> > > +          - ti,pcmd3140
> > > +          - ti,taa5212
> > > +          - ti,tad5212
> > > +          - ti,pcmd3180
> >
> > This one is duplicated.
> accept
> >
> > > +
> >
> >
> > Best regards,
> > Krzysztof