From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbcHHLgx (ORCPT ); Mon, 8 Aug 2016 07:36:53 -0400 Received: from mout.web.de ([212.227.15.14]:64919 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcHHLgv (ORCPT ); Mon, 8 Aug 2016 07:36:51 -0400 Subject: Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() To: Lee Jones References: <4dcb4cab-e2cc-87c0-9cfc-d140f185254b@users.sourceforge.net> <20160805075511.GN5243@dell> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <0a2ef320-a95a-2611-2554-a2a83838fb9b@users.sourceforge.net> Date: Mon, 8 Aug 2016 13:36:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160805075511.GN5243@dell> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ZFkirTEQF+3BjsLDRRjJDtbHJ39S5CMepr9BEc5HPkIsthnumjc pWp0NUIxpzm80QmEs+gL068BRvd/4a1dcqmAOetry/1qF8fGICm6Flyij4VEhQnDrJoYlve 0EHYz8fFvyH8U4hGTyF5UI6r42rxc9KJJHjJuaqvZal7lf+r/LxW/1WCTMAWl9PaelI7L+C v/Qa+7geSsMx0RrUZMseQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:hQ4PvtYojq8=:4MV81okVqf/fexAykvYd07 JabLGO8yNwBDAQjPO5JICNT+a8zV8QoGCVoGuVF4vNzMPhPHio0aNLxRh2QaVGpbXDSivJZbn KxPrFXSLmYal5rtzWTCvi7u3t5wi2RgeWKUB/ySxP0eksNlUHyVvqjkwRuvnIki2yIuSjjkiP BxuK6xxVyBenBSvrqf3vtR1aBGS1JET9nD2N8BMeQcfCfv02ckdiuZSzO/d6+JznUGW3xh9Sk jRCaWYmBkR/0i3rfRY4cD+La/9sdR3+gPoVI/L9QuDn4Koqo3azl+OAwe9Ka/ZItFhtF4mRbu rpW0C4F4Pg/m3LRKzKHvR0e+Tb72oNEYPUHmTOufYcGK7TaHOpU4f6X8u0/dm/b9t3DiDsqHR fxcr3L6BRYKVb8vsNIvJ7d4NLfek67vQO2XXfocxkWAfQ5G8Ff0pzCXugK1QYxlNF8saE4hOZ F4vcgBNq5SdZvgrjGMUwsvMNLJ/cBh8pwROLoBP6/zFoWSQmAC2IBs1bQURbx33OJXhR8lknC lRElBLD07Wit+x2qkJMPLAbkNufVAZdCE4sEMpjYqyhMMi5AScol2IbrTPVl4WWbzsg0qFFQr V3r5H+8wQ77FGSqnetBcASupOHPXcLdfSwA9lbncrJAz8KePB/4PX7xMYmF0eeDIJsBup32sm BMjdGMkeT7Pk5qs2xLtLpoxE8Z1C7GdDT+3Jf6iEqJ/gZenTMH+bTUAM27/BtzdA0VIjU+uKp Lbt7erxkizf/bXZCT04I9+Ydp/EeV3GZM8vhADLLflnjgnJdLoK2zzM9x08SYtgg5isah/aj5 I+tf5OT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> v4: Further feedback was integrated into this message. > > This is not a good change-log. What actually changed? Which kind of information would you find more useful in this case? >> @@ -222,19 +222,20 @@ static struct device *add_child(struct i2c_client *client, const char *name, >> status = platform_device_add_resources(pdev, &r, 1); >> if (status < 0) { >> dev_dbg(&pdev->dev, "can't add irq\n"); >> - goto err; >> + goto put_device; >> } >> } >> >> status = platform_device_add(pdev); >> + if (status) >> + goto put_device; >> >> -err: >> - if (status < 0) { >> - platform_device_put(pdev); >> - dev_err(&client->dev, "can't add %s dev\n", name); >> - return ERR_PTR(status); >> - } >> return &pdev->dev; >> + >> +put_device: >> + platform_device_put(pdev); >> + dev_err(&client->dev, "failed to add device %s\n", name); > > ... and remove this line. Do you really want that this error message should be deleted? How does this response fit to your request to introduce such a message for the function "add_numbered_child" (on 2016-06-08)? https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1162299.html https://lkml.org/lkml/2016/6/8/467 Regards, Markus