From: Jens Axboe <axboe@kernel.dk>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Christoph Hellwig" <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk
Date: Wed, 26 Apr 2023 18:26:11 -0600 [thread overview]
Message-ID: <0a57896e-3f61-7761-f03d-e47f0c21be7e@kernel.dk> (raw)
In-Reply-To: <862c1901-ee6e-44e5-8906-4bb1c3893372@t-8ch.de>
On 4/26/23 5:12?PM, Thomas Wei?schuh wrote:
> Hi Martin, Christoph, Jens,
>
> On 2023-03-20 07:56:58-0400, Martin K. Petersen wrote:
>>> The embedded member integrity_kobj member of struct gendisk violates
>>> the assumption of the driver core that only one struct kobject should
>>> be embedded into another object and then manages its lifetime.
>>>
>>> As the integrity_kobj is only used to hold a few sysfs attributes it
>>> can be replaced by direct device_attributes and removed.
>>
>> Looks good to me and passed a quick test on a couple of systems. Thanks
>> for cleaning this up!
>>
>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> Am I getting some part of the process for block/ wrong?
Sorry, I missed this series. I'll queue it up for 6.4.
> It seems my patches for the block subsystem are having a hard time
> getting merged.
>
> * https://lore.kernel.org/all/20221110052438.2188-1-linux@weissschuh.net/
This one is missing nbd review. It's unfortunately not uncommon to need
to re-ping on something like this, if you don't get a timely review.
This is not specific to this patch, just in general. Things get missed.
> * this series
> * https://lore.kernel.org/all/20230419-const-partition-v2-0-817b58f85cd1@weissschuh.net/
This one is just a week old, and coming into the merge window. Generally
takes longer at that time, as it's late for that merge window, and folks
are busy with getting things ready. If nothing happens on this one, I'd
suggest resending past -rc1 when folks are more ready to review and
queue things up for the next release.
--
Jens Axboe
next prev parent reply other threads:[~2023-04-27 0:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 17:36 [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk Thomas Weißschuh
2023-03-18 17:36 ` [PATCH v3 1/3] blk-integrity: use sysfs_emit Thomas Weißschuh
2023-03-20 6:14 ` Christoph Hellwig
2023-03-18 17:36 ` [PATCH v3 2/3] blk-integrity: convert to struct device_attribute Thomas Weißschuh
2023-03-20 6:14 ` Christoph Hellwig
2023-03-18 17:36 ` [PATCH v3 3/3] blk-integrity: register sysfs attributes on struct device Thomas Weißschuh
2023-03-20 6:15 ` Christoph Hellwig
2023-03-20 11:56 ` [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk Martin K. Petersen
2023-04-26 23:12 ` Thomas Weißschuh
2023-04-27 0:26 ` Jens Axboe [this message]
2023-04-27 6:00 ` Thomas Weißschuh
2023-04-27 0:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a57896e-3f61-7761-f03d-e47f0c21be7e@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox