From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 5/5] watchdog: qcom: add support to read the restart reason from IMEM
Date: Thu, 17 Apr 2025 11:49:23 +0530 [thread overview]
Message-ID: <0a774c34-e82d-4ff0-aa3f-4f348f4c2296@oss.qualcomm.com> (raw)
In-Reply-To: <4e9621c2-f347-4cba-9422-b14f96ee4c0b@oss.qualcomm.com>
On 4/16/2025 8:21 PM, Konrad Dybcio wrote:
>> .max_tick_count = 0xFFFFFU,
>> };
>>
>> +static int qcom_wdt_get_restart_reason(struct qcom_wdt *wdt,
> double space> + const struct qcom_wdt_match_data *data)
>
> Please align this
Ack.
>> +{
>> + struct regmap *imem;
>> + unsigned int val;
>> + int ret;
>> +
>> + imem = syscon_regmap_lookup_by_compatible(data->compatible);
> I still think nvmem could be better here, as it allows to plug in
> more magic values
Sure, I will be on vacation next week. I shall check on how to use nvmem
here once I'm back.
>
> Konrad
next prev parent reply other threads:[~2025-04-17 6:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 8:29 [PATCH v2 0/5] Add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-04-16 8:29 ` [PATCH v2 1/5] dt-bindings: sram: qcom,imem: Document IPQ5424 compatible Kathiravan Thirumoorthy
2025-04-21 19:12 ` Rob Herring (Arm)
2025-04-16 8:29 ` [PATCH v2 2/5] arm64: dts: qcom: ipq5424: Add the IMEM node Kathiravan Thirumoorthy
2025-04-16 14:52 ` Konrad Dybcio
2025-04-16 8:29 ` [PATCH v2 3/5] dt-bindings: watchdog: separate out the IPQ5424 compatilble Kathiravan Thirumoorthy
2025-04-21 19:43 ` Rob Herring
2025-04-28 4:02 ` Kathiravan Thirumoorthy
2025-04-16 8:29 ` [PATCH v2 4/5] arm64: dts: qcom: ipq5424: drop the fallback WDT compatible Kathiravan Thirumoorthy
2025-04-21 19:44 ` Rob Herring
2025-04-16 8:29 ` [PATCH v2 5/5] watchdog: qcom: add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-04-16 14:51 ` Konrad Dybcio
2025-04-17 6:19 ` Kathiravan Thirumoorthy [this message]
2025-04-30 14:28 ` Konrad Dybcio
2025-04-30 14:58 ` Kathiravan Thirumoorthy
2025-05-01 0:01 ` Bryan O'Donoghue
2025-05-02 4:42 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a774c34-e82d-4ff0-aa3f-4f348f4c2296@oss.qualcomm.com \
--to=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox