From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4794EC433E2 for ; Tue, 15 Sep 2020 15:23:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5F84206A2 for ; Tue, 15 Sep 2020 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600183387; bh=N9yGY1aXOgj8bD3rTeab7VM/6L6jqcYODfBu/4dZQGM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=elS3wLyqStL81K8pxFoeiad7pGKrGwp7ttdvJU8GeCMKezu51m6rVtOo6RBIIQJNs 9EHnE6ct3lvbnoa0asXM2+Ba/Oxp6/5XYBoz6jeiPUPSOrdZiyhFqS78iI6wG1Sylw jckbrApmxUu+1+1YRiPKaJbv5aPh62UGSoi+lAQc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727428AbgIOPWj (ORCPT ); Tue, 15 Sep 2020 11:22:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:53854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbgIOOwU (ORCPT ); Tue, 15 Sep 2020 10:52:20 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B313206DC; Tue, 15 Sep 2020 14:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600181537; bh=N9yGY1aXOgj8bD3rTeab7VM/6L6jqcYODfBu/4dZQGM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Jbgi3oTgKCpRS/gcC9HQAD47dKQc/oM65Tos9j05uzQrWfx4loznW5bLcAkc7yYSH oZ39xph87f6693yZghtnM8+YJL7WWunTt6QrvJhm8Z4MzKNY6TYqcWqEpy7/8nPz/I tYnVVlP2EOReRmi0uWS5VUyUGVnJfqJ/ydj0TPx0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kICJb-00C2UB-8i; Tue, 15 Sep 2020 15:52:15 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 15 Sep 2020 15:52:15 +0100 From: Marc Zyngier To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Jason Cooper , kernel-team@android.com Subject: Re: [PATCH 1/2] irqchip/gic: Handle non-standard SGI deactivation on Samsung's Franken-GIC In-Reply-To: References: <20200915133944.1285456-1-maz@kernel.org> <20200915133944.1285456-2-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <0a9212ef8a350bb78a145dab704a580e@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-15 15:06, Marek Szyprowski wrote: > On 15.09.2020 15:39, Marc Zyngier wrote: >> The GIC available on some of Samsung's A9-based platform is >> thankfully one of a kind. On top of not presenting a banked >> programing model (each CPU has its own base addresses for both >> distributor and CPU interface), it also encodes the source CPU >> for SGIs in the INTID read from IAR, and requires this exact >> value to be written back to EOI. >> >> Without this, interrupts are never deactivated, and the kernel >> grinds to a halt. >> >> Work around it by stashing the INTID for in-flight SGIs, and >> using that value on EOI. This only works because we don't nest >> SGIs. >> >> Reported-by: Marek Szyprowski >> Fixes: ac063232d4b0 ("irqchip/gic: Configure SGIs as standard >> interrupts") >> Signed-off-by: Marc Zyngier > > Works fine, thanks! > > Tested-by: Marek Szyprowski Thanks for having reported the failure, and your patience with testing all kind of random things! ;-) M. -- Jazz is not dead. It just smells funny...