Re: [PATCH] iio: humidity: hdc3020: fix temperature offset

Dimitri Fedrau
2024-01-25T11:08:58Z

Am Thu, Jan 25, 2024 at 11:49:25AM +0100 schrieb Nuno Sá:
> Hi Dimitri,
>
Hi Nuno,

> On Thu, 2024-01-25 at 11:26 +0100, Dimitri Fedrau wrote:
> > The temperature offset should be negative according to the datasheet.
> > Adding a minus to the existing offset results in correct temperature
> > calculations.
> >
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > ---
>
> This is a fix. You're missing a Fixes: tag in your commit message.
> git log --grep="Fixes:" should give you some examples...
>
Will fix this and resend the patch. Thanks for your help.

Best regards,
Dimitri
> With that, feel free to add:
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> >  drivers/iio/humidity/hdc3020.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
> > index 4e3311170725..ed70415512f6 100644
> > --- a/drivers/iio/humidity/hdc3020.c
> > +++ b/drivers/iio/humidity/hdc3020.c
> > @@ -322,7 +322,7 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev,
> >   if (chan->type != IIO_TEMP)
> >   return -EINVAL;
> >
> > - *val = 16852;
> > + *val = -16852;
> >   return IIO_VAL_INT;
> >
> >   default:
>