From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753212AbbCPJzb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 05:55:31 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:38769 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750862AbbCPJz1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 05:55:27 -0400
Message-ID: <0ac0be987e1d6b8bdfd524f14c83fcb4.squirrel@www.codeaurora.org>
In-Reply-To: <20150313195425.GA16977@qualcomm.com>
References: <1426268992-19298-1-git-send-email-sricharan@codeaurora.org>
    <1426268992-19298-7-git-send-email-sricharan@codeaurora.org>
    <20150313195425.GA16977@qualcomm.com>
Date: Mon, 16 Mar 2015 09:55:26 -0000
Subject: Re: [PATCH 6/6] dts: msm8974: Add dma channels for blsp2_i2c1 node
From: sricharan@codeaurora.org
To: "Andy Gross" <agross@codeaurora.org>
Cc: "Sricharan R" <sricharan@codeaurora.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, galak@codeaurora.org,
        dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
User-Agent: SquirrelMail/1.4.22-4.el6
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-Priority: 3 (Normal)
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> On Fri, Mar 13, 2015 at 11:19:52PM +0530, Sricharan R wrote:
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>
> Reviewed-by: Andy Gross <agross@codeaurora.org>
>
>>  arch/arm/boot/dts/qcom-msm8974.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
>> b/arch/arm/boot/dts/qcom-msm8974.dtsi
>> index 3f648ae..1ec7ec5 100644
>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
>> @@ -246,6 +246,8 @@
>>  			clock-names = "core", "iface";
>>  			#address-cells = <1>;
>>  			#size-cells = <0>;
>> +			dmas = <&blsp2_dma 20>, <&blsp2_dma 21>;
>> +			dma-names = "bam-tx", "bam-rx";
>
> more of a nit, but the bam- is unnecessary.  it's just rx/tx.

  Ok, will change it.

Regards,
 Sricharan