From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 031CDC433B4 for ; Fri, 14 May 2021 18:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF53561440 for ; Fri, 14 May 2021 18:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233408AbhENSac (ORCPT ); Fri, 14 May 2021 14:30:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:36482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbhENSab (ORCPT ); Fri, 14 May 2021 14:30:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6694561442; Fri, 14 May 2021 18:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621016960; bh=7Rxzqbp9zx/CR6YJmm0t2HgR3O+2xjtDuDGUkpxonvU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tXUuvnKNYt6ogg+Zrg5ozgoGzCOEnODIzSMGsvm8iY+ju6dubP+7iYuQoEISYmJyn so4rLbvFvF/5S7fiQnO5jXfAtFmSDV4btsQfL5vGpLsSUsQMza1TIyntT3DDd1N/5s zVKDugctkRT3TgldWl5cJRC9A1RFq+WuXH3tvZPL7sKQ5a00c3MT5JQdbP+4EUPxg8 CxodPO+WQE0Rgmys74B9XPUhDgsabASGCfTmcQPxynTUy1MzqHVwyUb4ljwenAOKhX +FKBPUI8+fFdTngYGFhdwwd3LsdPYYaQZ7RA7QiomlgpM7oe0tjsToYTzsi7ztsdhZ C6kBUHRko2P2w== Subject: Re: [PATCH] kcsan: fix debugfs initcall return type To: Arnd Bergmann , Marco Elver , Nick Desaulniers , "Paul E. McKenney" , Greg Kroah-Hartman Cc: Arnd Bergmann , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com References: <20210514140015.2944744-1-arnd@kernel.org> From: Nathan Chancellor Message-ID: <0ad11966-b286-395e-e9ca-e278de6ef872@kernel.org> Date: Fri, 14 May 2021 11:29:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210514140015.2944744-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/14/2021 7:00 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang points out that an initcall funciton should return an 'int': > > kernel/kcsan/debugfs.c:274:15: error: returning 'void' from a function with incompatible result type 'int' > late_initcall(kcsan_debugfs_init); > ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ > include/linux/init.h:292:46: note: expanded from macro 'late_initcall' > #define late_initcall(fn) __define_initcall(fn, 7) > > Fixes: e36299efe7d7 ("kcsan, debugfs: Move debugfs file creation out of early init") > Signed-off-by: Arnd Bergmann For the record, this requires CONFIG_LTO_CLANG to be visible. Reviewed-by: Nathan Chancellor > --- > kernel/kcsan/debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c > index c1dd02f3be8b..e65de172ccf7 100644 > --- a/kernel/kcsan/debugfs.c > +++ b/kernel/kcsan/debugfs.c > @@ -266,9 +266,10 @@ static const struct file_operations debugfs_ops = > .release = single_release > }; > > -static void __init kcsan_debugfs_init(void) > +static int __init kcsan_debugfs_init(void) > { > debugfs_create_file("kcsan", 0644, NULL, NULL, &debugfs_ops); > + return 0; > } > > late_initcall(kcsan_debugfs_init); >