From: Zhiyuan Wan <kmlinuxm@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>, andrew@lunn.ch
Cc: linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, willy.liu@realtek.com
Subject: Re: [PATCH net-next] net: phy: realtek: disable broadcast address feature of rtl8211f
Date: Tue, 3 Dec 2024 21:21:20 +0800 [thread overview]
Message-ID: <0ad27909-3d43-4c26-a69f-d0c8846f38a6@gmail.com> (raw)
In-Reply-To: <af9e2342-be01-41a8-9099-aeee6cbed258@gmail.com>
On 2024/12/3 21:18, Heiner Kallweit wrote:
> On 03.12.2024 13:54, Zhiyuan Wan wrote:
>
> Why PTR_ERR()? Did you even compile-test?
>
I made a test on a real mt7621 based hardware,
I misunderstood what PTR_ERR() means.
>
> And more formal hints:
> - If you send a new version of a patch, annotate it accordingly.
> - Allow 24h before sending a new version
> - Include a change log
>
> https://docs.kernel.org/process/submitting-patches.html
> https://www.kernel.org/doc/html/v6.1/process/maintainer-netdev.html
>
Ok, thank you.
next prev parent reply other threads:[~2024-12-03 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 12:54 [PATCH net-next] net: phy: realtek: disable broadcast address feature of rtl8211f Zhiyuan Wan
2024-12-03 13:18 ` Heiner Kallweit
2024-12-03 13:21 ` Zhiyuan Wan [this message]
2024-12-04 4:47 ` kernel test robot
2024-12-04 7:36 ` kernel test robot
2024-12-04 7:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ad27909-3d43-4c26-a69f-d0c8846f38a6@gmail.com \
--to=kmlinuxm@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox