From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D819BC2BA2B for ; Wed, 15 Apr 2020 06:36:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5D4F206F9 for ; Wed, 15 Apr 2020 06:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634910AbgDOGgt (ORCPT ); Wed, 15 Apr 2020 02:36:49 -0400 Received: from mga12.intel.com ([192.55.52.136]:33899 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393565AbgDOGg0 (ORCPT ); Wed, 15 Apr 2020 02:36:26 -0400 IronPort-SDR: AxuWUswikhaQHgE9NbIcR4k/XrGOsrf6O51f7y6KnLBDatEdq7L/s6mXCiIN7CYhFGXmkAv9JF Q8gfGjalKhfg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 23:36:26 -0700 IronPort-SDR: e6xHGQuPW0GE2LEJRgwBaaQuNwmEtvc/TZ2WPBNJCcxxDlhT3Yrpnh18pXIf/KDAcMJ1v7zZbH nGNmd7m4gNaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="363591408" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.210.208]) ([10.254.210.208]) by fmsmga001.fm.intel.com with ESMTP; 14 Apr 2020 23:36:20 -0700 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, Joerg Roedel Subject: Re: [PATCH v2 07/33] iommu: Add probe_device() and remove_device() call-backs To: Joerg Roedel , Will Deacon , Robin Murphy , Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , David Woodhouse , Andy Gross , Bjorn Andersson , Matthias Brugger , Rob Clark , Heiko Stuebner , Gerald Schaefer , Thierry Reding , Jonathan Hunter , Jean-Philippe Brucker References: <20200414131542.25608-1-joro@8bytes.org> <20200414131542.25608-8-joro@8bytes.org> From: Lu Baolu Message-ID: <0ad37581-b464-30ac-c503-4c0daaf43867@linux.intel.com> Date: Wed, 15 Apr 2020 14:36:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200414131542.25608-8-joro@8bytes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/14 21:15, Joerg Roedel wrote: > From: Joerg Roedel > > Add call-backs to 'struct iommu_ops' as an alternative to the > add_device() and remove_device() call-backs, which will be removed when > all drivers are converted. > > The new call-backs will not setupt IOMMU groups and domains anymore, > so also add a probe_finalize() call-back where the IOMMU driver can do > per-device setup work which require the device to be set up with a > group and a domain. The subject is inaccurate. probe_device() and release_device() are added to replace the add and remove pair. Best regards, baolu