From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0062F3290BD for ; Fri, 12 Jun 2026 17:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781285681; cv=none; b=CigunEb+DzYHLZH0AOg5ziT7s33yddTgQcl7tJMw8H5j6E+9wIp8Rwgmjj+pBzgEPuIyoMQgUnccuJFnD5cTotHaNGtdphcS+crwFgleSaHFnTjEySwrJ8PlT9y1UJVY0zK2w7H534YHkG45t0f7i5/nOoSDKDbslbN6Qt1bCDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781285681; c=relaxed/simple; bh=IvywPrYtqHwOPWtPbL5ec8PVlYD1azkdeorAonyzRE0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BxR8nj8Ppl4+fs7CQrdapIsLbXOaIVFw0iB1Tvgj8p2NlQq2s3JG/HRz/X3AJzYKZEU0f9dc3BMIi5myFg9V1ewqBX0+yRi/pCOByeTQMTX4H7pssWgvl7AEso1ojm0jpXmV/tEWibeBP1OyfLb5HTYn2ME0BmmuYDVtEK/DdyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=c6WhmD5u; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="c6WhmD5u" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-2bf55c39e16so10620345ad.0 for ; Fri, 12 Jun 2026 10:34:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781285679; x=1781890479; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LK+0/7C2rh+DDX++KBE74peykTPgebClJfikfMK5nUQ=; b=Njsvfb7WuEJyonB71zFhpaTWuULzhbytLW/YTLLxoDkmKMLJ+bi+ZJ6SfZwSWjfJMP aNOyV2UMl4pqS61tkktWAVkT1HQBJg8jJKHdBfHgtatINQBYJYcuyCrHfAnv1PtV8n+n aiEewtYt7n/RhJIAXEoZeGoAnyIQb9JOuW7UJs3ZcHs+9znr+Uit4SN4WpMOWIK2y/p1 UvN4M75JvtFV/AKz2objvVSchwUcBZEP3GhHbHfVa2tmweUpmUj5H8koLI9BDFUEzlPL cFcrkrHrsXsGzRnln8RJUz82W2xQzH50uRzYK23eIKuiUE6+T5NBKweZqw6cUuVun+0f t83Q== X-Forwarded-Encrypted: i=1; AFNElJ/vi534u7BlwqTt/7qn+ez3E3cg72zz+GzvEaWc8P18JozlB3C8n99ZCi6OaV9wsyGcM1e9w9iatLOFcsA=@vger.kernel.org X-Gm-Message-State: AOJu0YzdOLtddNrhjyoy1+OLE87/VOzbV49Ih0EccflIZLZ8AQNX6ZP9 hJtHiBZoVlS4FuSzEgP9EQD3DKdUdweNLAN/TPPk/41LPkF+AD0rENDDzqIoEyjshCq6AlDKeCT zfbiulfwh3U1M6GLid2e315Pc5+m8roehvYiTQX5ddVD4F0o5CFgkq1HqObnlzAXU3V5ktUGlpk GRhpYN0hD+pQGNMtwxdGY1YqedKiEeRHEMPMbw/e14OLWvCvRaW+ppUY5dTrLjo2GccTX34abmB vjO4x7ztVoeA7ZmQg== X-Gm-Gg: Acq92OFcTvZkGcGa/40SWzvhfB4XSHgflmi36ydmtx8bS+QB34pRKJzZnqYpZn+fY28 jj2RFwF2tDkE9tW5f72mQ0ChUsPEvKIVv3vfB8iqpqtq7n8jautYhfb5d29s1weIzC1IdGpXADu XqtuzDU4sDz1eoVdBczjZK8JHwu5yzb5+0jmkrMX89X/npyJ510eIUNI34SPA1pcxfCl2noC8KK wWrzI95IWA9orZpqLiBExOnj5+M7ONu6k++oJyMFj3ZOGYmykEYrn7mA8NsdDOc9PVhn/k9vghj 9mTXYYpXbz55PQgoz34QZocHl2ofRbEovyxOPdDqrjSV8Dzsex5HR71qgfalZ/JPqldt5ItDpV8 uSkKniUOLaOLWnYigr3KQMfSybm/IWDWrUssFBlrPFirJOvRXY5sETjif3yScp06e1/Q28GOFIh tCC52lPW3szSkJwMOB0vGEeKvisdWx1X4TlR2N5GBW11J2n62/3xgnRkAHsw== X-Received: by 2002:a17:903:b8f:b0:2c0:c262:b924 with SMTP id d9443c01a7336-2c42e834bd0mr31528415ad.13.1781285679170; Fri, 12 Jun 2026 10:34:39 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-121.dlp.protect.broadcom.com. [144.49.247.121]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2c432e7feb1sm1964395ad.36.2026.06.12.10.34.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jun 2026 10:34:39 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-304ea42b025so767076eec.0 for ; Fri, 12 Jun 2026 10:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1781285678; x=1781890478; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LK+0/7C2rh+DDX++KBE74peykTPgebClJfikfMK5nUQ=; b=c6WhmD5uZzFAHFGm8SNJFAlc/1T6QH05gfKNI2jz20E2zjgP9w6RKdZQAJvWeNvkHi SV+JMbLx41DjSBKy6ypGb/Aaslag/yvG0fAsdzVJIdkAhKM1f3Mt9NTqIOtMIccFgJet Ww4OE+eohqCErPwTnO8KXMEuqO8dttURploVo= X-Forwarded-Encrypted: i=1; AFNElJ+2N/WRo2ZnscA5nYVrdPv5zt3SXZWzBR+jJNAQzPp+93pjAnWt/Jnk0b0Vj8QXHk5o3tW6PPGQova/P+o=@vger.kernel.org X-Received: by 2002:a05:7300:66c7:b0:2d2:d5a3:e97c with SMTP id 5a478bee46e88-3081e46e982mr1621442eec.12.1781285677652; Fri, 12 Jun 2026 10:34:37 -0700 (PDT) X-Received: by 2002:a05:7300:66c7:b0:2d2:d5a3:e97c with SMTP id 5a478bee46e88-3081e46e982mr1621430eec.12.1781285676963; Fri, 12 Jun 2026 10:34:36 -0700 (PDT) Received: from [10.14.7.225] ([192.19.161.248]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e48e412sm4615599eec.4.2026.06.12.10.34.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 10:34:36 -0700 (PDT) Message-ID: <0ada80c4-0ad0-4475-9a5c-173ead88a4dc@broadcom.com> Date: Fri, 12 Jun 2026 10:34:34 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: bcmgenet: Use weighted round-robin TX DMA arbitration To: Nicolai Buchwitz Cc: Ovidiu Panait , opendmb@gmail.com, florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610085238.56300-1-ovidiu.panait.rb@renesas.com> <2f7e70123887fcfd8bbf4ce92f73574d@tipi-net.de> <69d920a3b52cc049dc1b96a9c7d5e3b6@tipi-net.de> Content-Language: en-US From: Justin Chen In-Reply-To: <69d920a3b52cc049dc1b96a9c7d5e3b6@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 6/12/26 12:37 AM, Nicolai Buchwitz wrote: > On 11.6.2026 19:27, Justin Chen wrote: > >> [...] > >>> AFAIK the existing queue mechanism dates back to the STB QoS use >>> cases Florian >>> had in mind when he wrote the driver, so let's hear what he has to >>> say on this. >>> >>> The change itself looks correct to me. My concern is the targeting. This >>> flips the default policy for every GENET user rather than fixing a >>> specific >>> defect, and Justin's series already called the persistent timeouts a >>> design >>> issue rather than a bug. >>> >>> So isn't this more net-next material than net with a broad Fixes: tag? >>> Please also add to the commit message that it drops the existing >>> priority >>> handling for rings 1-4. >>> >> >> I'm ok with these changes. Internally we no longer require priority >> queues. It is a legacy use case we no longer have. My idea was to >> remove the queues entirely and have one big queue. But I figured I >> would wait for Nicolai's XDP changes so we do not need to remove and >> re-add queues for XDP. This could be a stop-gap solution until that is >> done. > > Thanks Justin. IMHO XDP could benefit from a queue-refactoring prep. It > gets simpler on top of a single queue, and dropping q1-4 frees up a > bunch of BDs for the XDP ring instead of the 32 it has atm. > > Happy to take it on, or leave it to you :) > I am not going to say no to less work! Please do. Thanks, Justin >> [...] > > Thanks > Nicolai