From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7316AC2D0A3 for ; Mon, 26 Oct 2020 23:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38F3F207F7 for ; Mon, 26 Oct 2020 23:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406925AbgJZXfa (ORCPT ); Mon, 26 Oct 2020 19:35:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:30095 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406870AbgJZXfa (ORCPT ); Mon, 26 Oct 2020 19:35:30 -0400 IronPort-SDR: SwiQ0l4Dkrsh3PTiHHdulN6vvhV16kvnuBBCmIyngUc+NIHJphd83RFeyE9jcD67mCNduty4wP fLAB884Ktufg== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="232190068" X-IronPort-AV: E=Sophos;i="5.77,421,1596524400"; d="scan'208";a="232190068" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 16:35:28 -0700 IronPort-SDR: Wy/LuMKPwNf18D0QFgq6hb9EeytvQuq6a+akzIesatlG+Vfr76cUY7Gitum4qiO6+BbSTzbpMv v+2rQpyxuDMw== X-IronPort-AV: E=Sophos;i="5.77,421,1596524400"; d="scan'208";a="524475073" Received: from tanguye1-mobl2.amr.corp.intel.com (HELO [10.209.126.195]) ([10.209.126.195]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 16:35:25 -0700 Subject: Re: [PATCH v3] ASoC: Intel: boards: Add CML_RT1015 m/c driver To: Keith Tzneg , alsa-devel@alsa-project.org Cc: Cezary Rojewski , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kai Vehmanen , Guennadi Liakhovetski , Ranjani Sridharan , Naveen Manohar , Yong Zhi , Libin Yang , Krzysztof Kozlowski , Bard Liao , Sathyanarayana Nujella , Kuninori Morimoto , Fred Oh , Mac Chiang , Rander Wang , Keith Tzeng , Brent Lu , linux-kernel@vger.kernel.org References: <1603515087-4092-1-git-send-email-keith.tzeng@quantatw.com> From: Pierre-Louis Bossart Message-ID: <0ade3e3c-c55d-d137-0af2-b2b32c16cfd7@linux.intel.com> Date: Mon, 26 Oct 2020 14:22:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1603515087-4092-1-git-send-email-keith.tzeng@quantatw.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/20 11:51 PM, Keith Tzneg wrote: > From: Keith Tzeng > > Machine driver to enable RT5682 on SSP0, DMIC, HDMI and RT1015 AMP on > SSP1: Enabled 4 CH TDM playback with 24 bit data. Same comment for the third time: there is no reason to add an entire machine driver just to replace one amplifier by another. let's use an existing machine driver and use a quirk (DMI or table_id) to select the relevant amp for that device.