RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend

["Bharat Uppal" <bharat.uppal@samsung.com>]

> -----Original Message-----
> From: Bart Van Assche <bvanassche@acm.org>
> Sent: 04 August 2025 21:17
> To: Bharat Uppal <bharat.uppal@samsung.com>; linux-scsi@vger.kernel.org;
> linux-kernel@vger.kernel.org; James.Bottomley@HansenPartnership.com;
> martin.petersen@oracle.com; alim.akhtar@samsung.com;
> avri.altman@wdc.com; linux-samsung-soc@vger.kernel.org
> Cc: pankaj.dubey@samsung.com; aswani.reddy@samsung.com; Nimesh Sati
> <nimesh.sati@samsung.com>
> Subject: Re: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in
> reset on suspend
> 
> On 8/4/25 4:36 AM, Bharat Uppal wrote:
> > +static int fsd_ufs_suspend(struct exynos_ufs *ufs) {
> > +	exynos_ufs_gate_clks(ufs);
> > +	hci_writel(ufs, 0 << 0, HCI_GPIO_OUT);
> > +	return 0;
> > +}
> 
> Why '0 << 0' instead of just '0'? Isn't the latter easier to read?
Thanks for reviewing.
Indeed setting 0 is right, but in the same file ufs-exynos.c,  I have seen HCI_GPIO_OUT register configured using 0 << 0.
My intent here is to maintain coding style within the file.

With Regards
Bharat Uppal

> 
> Thanks,
> 
> Bart.