From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shen Lichuan <shenlichuan@vivo.com>,
s.nawrocki@samsung.com, linus.walleij@linaro.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v2] drivers: pinctrl: samsung: Use kmemdup_array instead of kmemdup for multiple allocation
Date: Fri, 23 Aug 2024 15:42:18 +0200 [thread overview]
Message-ID: <0b25b335-5817-4035-920d-e844435397a6@kernel.org> (raw)
In-Reply-To: <20240823114441.50648-1-shenlichuan@vivo.com>
On 23/08/2024 13:44, Shen Lichuan wrote:
> Let the kmemdup_array() take care about multiplication
> and possible overflows.
>
> Using kmemdup_array() is more appropriate and makes the code
> easier to audit.
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
> v1->v2: modified commit message and code format according to Linux coding style and submission process
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
I missed last time, subject is without "drivers:". I think only few
subsystems expect drivers.
You can get prefix for example with `git log --oneline --
DIRECTORY_OR_FILE` on the directory your patch is touching.
No need to resend, fixed up.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-23 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 11:44 [PATCH v2] drivers: pinctrl: samsung: Use kmemdup_array instead of kmemdup for multiple allocation Shen Lichuan
2024-08-23 13:41 ` Krzysztof Kozlowski
2024-08-23 13:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b25b335-5817-4035-920d-e844435397a6@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=s.nawrocki@samsung.com \
--cc=shenlichuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox