From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754886AbcIVGYO (ORCPT ); Thu, 22 Sep 2016 02:24:14 -0400 Received: from mout.web.de ([212.227.15.14]:57183 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbcIVGYM (ORCPT ); Thu, 22 Sep 2016 02:24:12 -0400 Subject: [PATCH 4/4] GPU-DRM-QXL: Adjust checks for null pointers in three functions To: dri-devel@lists.freedesktop.org, Bhaktipriya Shridhar , Daniel Vetter , David Airlie , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Tejun Heo , Thierry Reding References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <0b282ff2-cafe-0b51-912f-def4d840c4ef@users.sourceforge.net> Date: Thu, 22 Sep 2016 08:23:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:LAcNH85mItee3f3dIrlIB38gym0N6qTpPYphSHiTsScNgGtxZMh WDvnyqP49vuuKAqwqKBN63Mc2bwoI75pxhrZgXh8VDHJyLV5PUKQhdfr4Uw+Nw0ENFuUO0c DTP23vHMg28k9sS+DV0Ucjeoh65cV860x/Rg1XW4GUFlX0VRYIFPTbkkxu2qHMl/aWG/Li8 ttTKOd0bTgVxuu8595XcA== X-UI-Out-Filterresults: notjunk:1;V01:K0:PUDVkC4gyiM=:Zjjq2CwoPSIVDkZ8daofaV 1Pq7XpgEIunmjHXEUrAa4p5OjyKb9UhXlpxu/FnOyVmkyVzuSPFJKoijS/VKJEtQcwxV/Ynq/ dDvWJgmp1Eo1qVx4So5SWjWFyPONHgkJ/1O7l5sRbY/ig0tYg/najqgPeNaS0QgNcfMxcsMEn cnk4D93EU32dN887Smlto5w8u9uqXERpjHTkwmPku4fWwNgK2+AHW67/Uwkl29XOYAJFNodRv 20EytkflQNvmtVj/dPk81N1pDYoVoWkYtI0lS7cr6moBFWSrf6AmU9PTUeNAJHevh12/sMAS2 zPJgL7RCOwHl+DiuGGKTGvOpNgtkVCP3WnkmTuCXQGq/CvKeSXV/wO8l2Io1oZtbyylC7hSVU xH+ouw4htR7f8IUCpBptT5iFTjfd3UhQTfYvQeIU56vK24KxNp07JQYN2oK9LJRfGk5z2ChYn M6s6y/WRbQNReNZM1OeOdA1ZcJEh6RhXTpLiA69CIek+Wpc3AQJ/sPy3BJuTFfgHFJMtmy7K0 HX+JKliOg7bEc0gwa6m70xMyN9zO23xvL861trBSaxVro0Cd9jZ9Zh0jkxo1/JMJeKp8/NLNG MRpxXmc8vpfDB6DCKyNoJ46c4wVnjDqZh1VmhRsJj34YyRjo8CbpxC/9TWAyY3duScqXbcQ2m iV3NlrbI6ZkFUC6FTL0NbSS+ee5JKFYG3BmB/cUQ04pZjqzJwqWSWuOldCUv61kmGrDy6Q7U/ jAPIVeK6nS/GKsz1eJj/ZXB9JbM9XCNrN+S+4GllDuLJ0BldOAR2wltxHAfJzp97KiuN8/CMi tdMkVXg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 22 Sep 2016 08:00:08 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/gpu/drm/qxl/qxl_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index f8f0261..f594430 100644 --- a/drivers/gpu/drm/qxl/qxl_kms.c +++ b/drivers/gpu/drm/qxl/qxl_kms.c @@ -149,7 +149,7 @@ static int qxl_device_init(struct qxl_device *qdev, io_mapping_create_wc(qdev->surfaceram_base, qdev->surfaceram_size); } - if (qdev->surface_mapping == NULL) { + if (!qdev->surface_mapping) { /* 64bit surface bar not present (or mapping failed) */ sb = 1; qdev->surfaceram_base = pci_resource_start(pdev, sb); @@ -288,7 +288,7 @@ int qxl_driver_unload(struct drm_device *dev) { struct qxl_device *qdev = dev->dev_private; - if (qdev == NULL) + if (!qdev) return 0; drm_vblank_cleanup(dev); @@ -307,7 +307,7 @@ int qxl_driver_load(struct drm_device *dev, unsigned long flags) int r; qdev = kzalloc(sizeof(*qdev), GFP_KERNEL); - if (qdev == NULL) + if (!qdev) return -ENOMEM; dev->dev_private = qdev; -- 2.10.0