public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Julia Lawall <julia.lawall@lip6.fr>,
	Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH 2/4] Input-gameport: Delete an error message for a failed memory allocation
Date: Sat, 24 Sep 2016 15:47:42 +0200	[thread overview]
Message-ID: <0b438906-0b64-7635-801d-8edfe5bcd8dd@users.sourceforge.net> (raw)
In-Reply-To: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 24 Sep 2016 14:18:48 +0200

Omit an extra message for a memory allocation failure in this function.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/input/joystick/joydump.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/joystick/joydump.c b/drivers/input/joystick/joydump.c
index e515058..f9f6cbe 100644
--- a/drivers/input/joystick/joydump.c
+++ b/drivers/input/joystick/joydump.c
@@ -80,10 +80,9 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
 
 	timeout = gameport_time(gameport, 10000); /* 10 ms */
 	buf = kmalloc_array(BUF_SIZE, sizeof(*buf), GFP_KERNEL);
-	if (!buf) {
-		printk(KERN_INFO "joydump: no memory for testing\n");
+	if (!buf)
 		goto jd_end;
-	}
+
 	dump = buf;
 	t = 0;
 	i = 1;
-- 
2.10.0

  parent reply	other threads:[~2016-09-24 13:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-24 13:45 [PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect() SF Markus Elfring
2016-09-24 13:46 ` [PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect() SF Markus Elfring
2016-09-24 16:42   ` Dmitry Torokhov
2016-09-24 17:04     ` SF Markus Elfring
2016-09-24 13:47 ` SF Markus Elfring [this message]
2016-09-24 13:48 ` [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump" SF Markus Elfring
2016-09-24 16:41   ` Dmitry Torokhov
2016-09-24 16:55     ` SF Markus Elfring
2016-09-24 17:03       ` Joe Perches
2016-09-24 17:45         ` SF Markus Elfring
2016-09-24 18:01           ` Joe Perches
2016-09-24 18:45             ` SF Markus Elfring
2016-09-24 13:50 ` [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() SF Markus Elfring
2016-09-24 16:13   ` Joe Perches
2016-09-24 16:32     ` SF Markus Elfring
2016-09-24 16:39       ` Dmitry Torokhov
2016-09-24 17:20         ` SF Markus Elfring
2016-09-24 16:47       ` [PATCH 4/4] " Joe Perches
2016-09-24 19:50         ` SF Markus Elfring
2016-09-24 16:41     ` [PATCH 4/4] " SF Markus Elfring
2016-09-25  7:15     ` [PATCH v2 3/3] " SF Markus Elfring
2016-09-25  7:31       ` Joe Perches
2016-09-25  7:45         ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b438906-0b64-7635-801d-8edfe5bcd8dd@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox