From: Lance Yang <lance.yang@linux.dev>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: sean@ashe.io, linux-kernel@vger.kernel.org, pmladek@suse.com,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
joel.granados@kernel.org, mhiramat@kernel.org
Subject: Re: [v6 PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector
Date: Fri, 16 Jan 2026 10:22:34 +0800 [thread overview]
Message-ID: <0b4a76d3-9dcc-450c-9902-dc37b84eb2cb@linux.dev> (raw)
In-Reply-To: <446y53ztmkyw5pqp6klxwd74cvwbjoptzezurr6qxg46frieg3@mbwmglq2qth5>
On 2026/1/16 02:18, Aaron Tomlin wrote:
> On Thu, Jan 15, 2026 at 11:24:13AM +0800, Lance Yang wrote:
>> IIUC, we should just do:
>> - Patch 1: Full cmpxchg-based counting (Petr's POC), sysctl read-only
>> - Patch 2: Add write handler for userspace reset
>>
>> That way Patch 1 is the real logic change, and Patch 2 is just adding
>> the userspace interface.
>
> Hi Lance,
>
> Thank you for your feedback.
> If I am not mistaken, Joel suggested the following structure [1]:
>
> 1. Create a preparatory patch to change the data type to atomic_long_t
> 2. Introduce the required functionality to support a reset to "0"
>
> [1]: https://lore.kernel.org/lkml/d4vx6k7d4tlagesq55yrbma26i2nyt4tpijkme6ckioeyfqfec@txrs27niaj2m/
>
Yeah, either way works :)
But that way (changing to atomic with the old logic first, then
rewriting to the new logic) seems like it creates more churn
and makes review harder.
Or just all in one?
I'd hope Petr and Joel can comment.
next prev parent reply other threads:[~2026-01-16 2:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 2:32 [v6 PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector Aaron Tomlin
2026-01-15 2:32 ` [v6 PATCH 1/2] hung_task: Convert detection count to atomic_long_t Aaron Tomlin
2026-01-15 2:32 ` [v6 PATCH 2/2] hung_task: Enable runtime reset of hung_task_detect_count Aaron Tomlin
2026-01-15 3:06 ` Lance Yang
2026-01-15 18:24 ` Aaron Tomlin
2026-01-16 2:10 ` Lance Yang
2026-01-15 3:24 ` [v6 PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector Lance Yang
2026-01-15 18:18 ` Aaron Tomlin
2026-01-16 2:22 ` Lance Yang [this message]
2026-01-20 9:46 ` Petr Mladek
2026-01-20 11:48 ` Lance Yang
2026-01-23 0:59 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4a76d3-9dcc-450c-9902-dc37b84eb2cb@linux.dev \
--to=lance.yang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pmladek@suse.com \
--cc=sean@ashe.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox