public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	Andrew Morton <akpm@osdl.org>, Andy Whitcroft <apw@shadowen.org>,
	Andy Whitcroft <apw@shadowen.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org
Subject: [PATCH 1/6] mips: irix_getcontext will always fail EFAULT
Date: Thu, 16 Aug 2007 14:18:45 +0100	[thread overview]
Message-ID: <0b4bc89aa61d97708ca0f79ba02f6e60@pinky> (raw)
In-Reply-To: exportbomb.1187270320@pinky


Seems that a trailing ';' has slipped onto the end of the access_ok
check here, such that we will always return -EFAULT.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---
 arch/mips/kernel/irixsig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c
index 6980deb..28b2a8f 100644
--- a/arch/mips/kernel/irixsig.c
+++ b/arch/mips/kernel/irixsig.c
@@ -725,7 +725,7 @@ asmlinkage int irix_getcontext(struct pt_regs *regs)
 	       current->comm, current->pid, ctx);
 #endif
 
-	if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx)));
+	if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx)))
 		return -EFAULT;
 
 	error = __put_user(current->thread.irix_oldctx, &ctx->link);

  reply	other threads:[~2007-08-16 13:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-15 23:58 drivers/infiniband/mlx/mad.c misplaced ; Dave Jones
2007-08-16  0:40 ` Joe Perches
2007-08-16  2:19   ` Kok, Auke
2007-08-16  3:17     ` Joe Perches
2007-08-16  4:20       ` Kok, Auke
2007-08-16 10:21       ` [netfilter-core] " Patrick McHardy
2007-08-16 14:05     ` Andy Whitcroft
2007-08-16  8:46   ` Heiko Carstens
2007-08-16 10:22     ` Ilpo Järvinen
2007-08-16 11:01       ` Karsten Keil
2007-08-18 15:14         ` Daniel Schaffrath
2007-08-16 12:41       ` Satyam Sharma
2007-08-16 14:52   ` Jeff Dike
2007-08-17  6:54     ` [PATCH] hostfs: Remove pointless if statement Satyam Sharma
2007-08-17 13:54       ` Jeff Dike
2007-08-16 16:19   ` drivers/infiniband/mlx/mad.c misplaced ; Paul Mundt
2007-08-16  3:39 ` Roland Dreier
2007-08-16 13:18 ` [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals Andy Whitcroft
2007-08-16 13:18   ` Andy Whitcroft [this message]
2007-08-22 22:35     ` [PATCH 1/6] mips: irix_getcontext will always fail EFAULT Ralf Baechle
2007-08-16 13:18   ` [PATCH 2/6] powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICES Andy Whitcroft
2007-08-16 13:18   ` [PATCH 3/6] sh: remove extraneous ; on scif_sercon_putc wait loop Andy Whitcroft
2007-08-16 16:27     ` Paul Mundt
2007-08-16 13:19   ` [PATCH 4/6] infiniband: mlx4_MAD_IFC copies out response unconditionally Andy Whitcroft
2007-08-16 15:01     ` Roland Dreier
2007-08-16 13:19   ` [PATCH 5/6] irda_nl_get_mode: always results in failure Andy Whitcroft
2007-08-16 13:19   ` [PATCH 6/6] netfilter: xt_u32: fix length checks in u32_match_it Andy Whitcroft
2007-08-16 14:32     ` Patrick McHardy
2007-08-16 14:21   ` [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals Satyam Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b4bc89aa61d97708ca0f79ba02f6e60@pinky \
    --to=apw@shadowen.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox