From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ED63BE8FDC8
	for <linux-kernel@archiver.kernel.org>; Wed,  4 Oct 2023 02:45:39 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S240989AbjJDClP (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 3 Oct 2023 22:41:15 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37014 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229654AbjJDClO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Oct 2023 22:41:14 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9C2FAD
        for <linux-kernel@vger.kernel.org>; Tue,  3 Oct 2023 19:41:08 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00DDEC433C8;
        Wed,  4 Oct 2023 02:41:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1696387268;
        bh=eVHXKXrgwrMb2F/BFyQ7m49d0FIN0HEfGgy1Zm1UBz0=;
        h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
        b=qz26RcE1sZdQJLtl/NT6WLkkSGE7ajyPE/9yXbqemnV/aPcS5BXkao/r4wk1ithlc
         kKmdvqMoGYuCkdvxAlAqbMkXJjVMdJD3Evz2RQkK64jKzj8a/H5ayHeA1AHrL+nUJ4
         D4I/cbImn9QWsYcJCZYvtRZy3aWLIUThFdUETxZ9kI17bP9Hp3yRNLdJrXOUAQOuOR
         ds7kW+HQJUyONNDshPPHTicQKvgbv51QTNi81mPwHVpAGDqQ7RACbVkwTn3W6xcdGV
         f+id/zSpNbC+17Xm5KmIUluUpgbDn5TOfbU3DUaZaI6oZKshTWx9vALKm481QOGxct
         kwh3UER7CcXLw==
Message-ID: <0b7640c4-e6ea-33f9-9477-78a6ddcb195c@kernel.org>
Date:   Tue, 3 Oct 2023 20:41:07 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH] nexthop: Annotate struct nh_group with __counted_by
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
References: <20231004014445.work.587-kees@kernel.org>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20231004014445.work.587-kees@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/3/23 7:44 PM, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct nh_group.
> 
> Cc: David Ahern <dsahern@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  include/net/nexthop.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>