From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AAE71386C9; Fri, 31 Jan 2025 18:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738347974; cv=none; b=RWDuiY1TmXz0IEwWQGwbqfn6+pNtyq2lkE+QOdHAzwNBXnvLJS17SL3bDxPrROCtpVUHNko1j9yjdgUV+MhqGAMHpFEDrfbKXoUeuRiRJOrka5ORZANXdXzJEqt0WygpbfCnJxujeOtw0ycULCRFThHptR+4HwInmzK9WYd9YUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738347974; c=relaxed/simple; bh=Sr8eo5dnSu4s16FpqH5wmJig+RqhC1EFzoPlT6WRzuk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=S+Tj3htx2030/qJJaSBjtoYVPZReCw8JTNCoIo2NUg8PSLymyl2f5y2C8xy5d7L3sRLBHO0mqwOp0TuNzY6FZPqodBvbY1+qqVLYkQVy7dFQQ3zBmkYaX8HtXt7SRiuiBqu1Y6CpakFc1IrmN5PzMk3Djz3/gHCvVhXPkj45ujM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KdJOymT1; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KdJOymT1" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 50VIPxaT1709913 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2025 12:25:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1738347959; bh=QeW7OzaxjVMicPl3OoEn58LA3cfkF615oS67GkKAOiI=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=KdJOymT1PgcvvIC6RprKEToSc33IG9pN6+wckktn3M6wKY617/V181+34vgG3fUWz wcdPSurnYvFjI3bW5UCsMOTaUpiflcc1rTpM8fVyGgs3EqAUPhU1L2ym3nC6zg0zHU N63R4V118ZBFstOjWEMiSXTAHOp4ZG9r3J4M9z0Q= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 50VIPxiw045233 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 31 Jan 2025 12:25:59 -0600 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 31 Jan 2025 12:25:58 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 31 Jan 2025 12:25:58 -0600 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 50VIPwBL111109; Fri, 31 Jan 2025 12:25:58 -0600 Message-ID: <0b7cbf66-0c95-4ced-9cf7-cc5b953eebfe@ti.com> Date: Fri, 31 Jan 2025 12:25:58 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node To: Judith Mendez , Hari Nagalla CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , Devarsh Thakkar , Nishanth Menon , Vignesh Raghavendra , References: <20250127221631.3974583-1-jm@ti.com> <20250127221631.3974583-3-jm@ti.com> <8b152f81-0848-4f34-adcb-fee9b4f2fd7f@ti.com> <76f9e9e8-dd7c-e783-fccc-0b6f913ce753@ti.com> <390aa52e-e9f2-4ce3-ad1b-eac71f4a211c@ti.com> <6ab56868-b2d2-4b8a-ac06-d0d35a5e8998@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <6ab56868-b2d2-4b8a-ac06-d0d35a5e8998@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 1/30/25 4:40 PM, Judith Mendez wrote: > On 1/28/25 11:48 AM, Judith Mendez wrote: >> Hi Andrew, >> >> On 1/28/25 10:52 AM, Hari Nagalla wrote: >>> On 1/28/25 10:27, Andrew Davis wrote: >>>>> +    mcu_r5fss0: r5fss@79000000 { >>>>> +        compatible = "ti,am62-r5fss"; >>>>> +        #address-cells = <1>; >>>>> +        #size-cells = <1>; >>>>> +        ranges = <0x79000000 0x00 0x79000000 0x8000>, >>>>> +             <0x79020000 0x00 0x79020000 0x8000>; >>>>> +        power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; >>>> >>>> Newline here. >>>> >>>> Also this should be default "disabled". It can be set to "okay" >>>> in the board DTS file when the needed mboxes and memory-region >>>> are set. Speaking of that, where are those patches? This is >>>> incomplete without them and these nodes will not function. >>>> Same for the DSP patch. >>>> >>>> Andrew >>> Yes, by default needs to set the node state to "disabled". This is HW description of the wake-up domain components. Memory carve outs and mailbox assignments for IPC are a separate patch as it is configurable and distro dependent. >> >> Yes I plan to disable the nodes in each domain .dtsi file. >> >> Also yes, my understanding is that the memory carveouts could >> be a separate series if at all. Not sure if those patches can be >> sent upstream since they are distro dependent. Can anyone clarify >> if this is the case? >> > > As per offline discussion, I will include the memory carveouts in this > same series. It's usually good to fill in some details of "offline discussion" for folks on the list not in that conversation. By "distro dependent" we really mean firmware dependent. The carveouts are set in DT and then most firmware follows the same and hardcode these addresses. For example[0]. This works well as long as all the firmware uses these standard addresses. Problem is some legacy firmware did not, and so to use those firmware the DT would need modified. For AM62 and AM62A I'm not aware of any such firmware. So this is a bit of a non-issue and we can safely add the carveouts like we already do for all other K3 devices. Andrew [0] https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/beagle/beaglebone_ai64/beaglebone_ai64_j721e_main_r5f0_0.dts#L30 > ~ Judith > >> ~ Judith >> >