From: Quentin Schulz <quentin.schulz@free-electrons.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linus.walleij@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk,
lee.jones@linaro.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com,
thomas.petazzoni@free-electrons.com
Subject: Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features
Date: Tue, 26 Sep 2017 15:37:37 +0200 [thread overview]
Message-ID: <0bc7efe6-8d0e-ddae-617b-36e4357f76ce@free-electrons.com> (raw)
In-Reply-To: <20170926132709.od3myumh5xtungvs@flea>
[-- Attachment #1.1: Type: text/plain, Size: 1948 bytes --]
On 26/09/2017 15:27, Maxime Ripard wrote:
> On Tue, Sep 26, 2017 at 01:08:21PM +0000, Quentin Schulz wrote:
>> Hi Maxime,
>>
>> On 26/09/2017 15:00, Maxime Ripard wrote:
>>> On Tue, Sep 26, 2017 at 12:17:12PM +0000, Quentin Schulz wrote:
>>>> +static const struct axp20x_desc_pin axp209_pins[] = {
>>>> + AXP20X_PIN(AXP20X_PINCTRL_PIN(0, "GPIO0"),
>>>> + AXP20X_FUNCTION(0x0, "gpio_out"),
>>>> + AXP20X_FUNCTION(0x2, "gpio_in"),
>>>> + AXP20X_FUNCTION(0x3, "ldo"),
>>>> + AXP20X_FUNCTION(0x4, "adc")),
>>>> + AXP20X_PIN(AXP20X_PINCTRL_PIN(1, "GPIO1"),
>>>> + AXP20X_FUNCTION(0x0, "gpio_out"),
>>>> + AXP20X_FUNCTION(0x2, "gpio_in"),
>>>> + AXP20X_FUNCTION(0x3, "ldo"),
>>>> + AXP20X_FUNCTION(0x4, "adc")),
>>>> + AXP20X_PIN(AXP20X_PINCTRL_PIN(2, "GPIO2"),
>>>> + AXP20X_FUNCTION(0x0, "gpio_out"),
>>>> + AXP20X_FUNCTION(0x2, "gpio_in")),
>>>> +};
>>>
>>> If all the functions are the same, and at the same offset, can't we
>>> just hardcode it, instead of having (and duplicate) all the logic
>>> below?
>>>
>>
>> AXP20X_PIN(AXP20X_PINCTRL_PIN(0, "GPIO0"),
>> AXP20X_GPIO_OUT,
>> AXP20X_GPIO_IN,
>> AXP20X_LDO,
>> AXP20X_ADC))
>>
>> That's what you mean?
>
> What I mean is:
>
> static int axp20x_get_func(char *func)
> {
> if (!strcmp(func, "gpio_out"))
> return 0;
>
> if (!strcmp(func, "gpio_in"))
> return 2;
>
> if (!strcmp(func, "ldo"))
> return 3;
>
> if (!strcmp(func, "adc"))
> return 4;
>
> return -EINVAL;
> }
>
GPIO2 on AXP209 does not support ldo nor adc.
GPIO1 on AXP813 does not support adc.
I find it more complex to handle those two cases in a function than by
hardcoding it in structures like above.
Moreover, nothing tells us that it would be the same offset for other PMICs.
Quentin
--
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-09-26 13:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 12:17 [PATCH v2 00/10] add pinmuxing support for pins in AXP209 and AXP813 PMICs Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl Quentin Schulz
2017-09-26 12:55 ` Maxime Ripard
2017-09-26 12:59 ` Quentin Schulz
2017-09-26 13:08 ` Chen-Yu Tsai
2017-10-05 20:50 ` Rob Herring
2017-09-26 12:17 ` [PATCH v2 02/10] pinctrl: axp209: add pinctrl features Quentin Schulz
2017-09-26 13:00 ` Maxime Ripard
2017-09-26 13:08 ` Quentin Schulz
2017-09-26 13:27 ` Maxime Ripard
2017-09-26 13:37 ` Quentin Schulz [this message]
2017-09-27 9:28 ` Maxime Ripard
2017-09-26 12:17 ` [PATCH v2 03/10] pinctrl: axp209: use drv_data of pinctrl_pin_desc to store pin reg Quentin Schulz
2017-09-26 13:01 ` Maxime Ripard
2017-09-26 13:17 ` Quentin Schulz
2017-09-26 13:45 ` Maxime Ripard
2017-09-29 17:27 ` kbuild test robot
2017-09-26 12:17 ` [PATCH v2 04/10] pinctrl: axp209: rename everything from gpio to pctl Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 05/10] pinctrl: axp209: add programmable gpio_status_offset Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 06/10] pinctrl: axp209: add support for AXP813 GPIOs Quentin Schulz
2017-09-26 13:12 ` Maxime Ripard
2017-09-26 12:17 ` [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Quentin Schulz
2017-09-26 13:14 ` Maxime Ripard
2017-09-28 19:06 ` Lee Jones
2017-09-26 12:17 ` [PATCH v2 08/10] ARM: dts: add dtsi for AXP813 PMIC Quentin Schulz
2017-09-26 13:16 ` Maxime Ripard
2017-09-26 13:53 ` Chen-Yu Tsai
2017-09-26 12:17 ` [PATCH v2 09/10] ARM: dts: sun8i: a711: include axp813 dtsi Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 10/10] ARM: dts: sun8i: bananapi-m3: " Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc7efe6-8d0e-ddae-617b-36e4357f76ce@free-electrons.com \
--to=quentin.schulz@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox