From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0684C433F5 for ; Tue, 7 Sep 2021 02:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4603610C7 for ; Tue, 7 Sep 2021 02:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231214AbhIGCYT (ORCPT ); Mon, 6 Sep 2021 22:24:19 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:42239 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbhIGCYI (ORCPT ); Mon, 6 Sep 2021 22:24:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630981382; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Reply-To: Sender; bh=Vf+adD7w2aYCznZWbb7pqeirNPG3QO9k1TYBCSLXyEs=; b=paMfmTc3C0od+0g1cl9aw6wfCTOeo3O/pAr23VNx4h6M//oWcVnmH0Z1H/BZnO+LHJipT3R2 kgkDRez59lMH4vWl5MfDuipsGTFyy58m1SlMWfrLTnfpD9ymSv3rvRFp0RH4H2xw9L8PteRg JA2XUGIf5JcWN/anxiVahSyE8U0= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 6136cd064d644b7d1cd2e183 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 07 Sep 2021 02:23:02 GMT Sender: bcain=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1D4F6C43460; Tue, 7 Sep 2021 02:23:02 +0000 (UTC) Received: from BCAIN (104-54-226-75.lightspeed.austtx.sbcglobal.net [104.54.226.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bcain) by smtp.codeaurora.org (Postfix) with ESMTPSA id 39DFEC4338F; Tue, 7 Sep 2021 02:23:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 39DFEC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Reply-To: From: "Brian Cain" To: "'Jiapeng Chong'" Cc: , References: <1630920794-81114-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1630920794-81114-1-git-send-email-jiapeng.chong@linux.alibaba.com> Subject: RE: [PATCH] trap: Fix warning comparing pointer to 0 Date: Mon, 6 Sep 2021 21:23:01 -0500 Message-ID: <0bcb01d7a38f$48dd1c20$da975460$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGJRnG986NR9eU5XtbXbE4uuM19CKw0kYjg Content-Language: en-us Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jiapeng Chong > Sent: Monday, September 6, 2021 4:33 AM > To: bcain@codeaurora.org > Cc: linux-hexagon@vger.kernel.org; linux-kernel@vger.kernel.org; > chongjiapeng > Subject: [PATCH] trap: Fix warning comparing pointer to 0 > > From: chongjiapeng > > Fix the following coccicheck warning: > > ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0. > > Reported-by: Abaci Robot > Signed-off-by: chongjiapeng > --- > arch/hexagon/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c > index edfc35d..3b6e0de 100644 > --- a/arch/hexagon/kernel/traps.c > +++ b/arch/hexagon/kernel/traps.c > @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, > unsigned long *fp, > } > > /* Attempt to continue past exception. */ > - if (0 == newfp) { > + if (!newfp) { > struct pt_regs *regs = (struct pt_regs *) (((void *)fp) > + 8); > Reviewed-by: Brian Cain