From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754969AbcIJHTJ (ORCPT ); Sat, 10 Sep 2016 03:19:09 -0400 Received: from mout.web.de ([217.72.192.78]:49905 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753725AbcIJHTI (ORCPT ); Sat, 10 Sep 2016 03:19:08 -0400 Subject: [PATCH 2/5] ATM-nicstar: Improve another size determination in get_scq() To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <0bd4a38e-cd33-ecda-ed3a-73f743ed46e2@users.sourceforge.net> Date: Sat, 10 Sep 2016 09:18:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Ethx38C7Co5NQ0K1g4Te0geXoVjQwNlEZfRS/cjPL6WVcFblxYJ oMhXL+TSagCA9EtvkMEk15h2O7MStF++DB3KbaM5eyfF2yDpI2LYSCkWTrUIB9/BuY77ZMQ WxeXSsrdVOLI/WYGJAGyQimGxhsCfKMZJCFn4Gb9hZ4Nq7J5x8Ua1WAFvTrykklNA7o0XFN beOYQoIKMy2P3Ifp/3cwA== X-UI-Out-Filterresults: notjunk:1;V01:K0:5wqQmohE5ks=:DIGcvRvWMaQSrwO8G8NmQk x9s0pNpdna0jMOL4vRFoypRG31Qkp5h38sXExSEo/IctC1towNMemY9rv2X4hxbi83+W0QD6b /rm0vuLogQQFXTMH5Ae0PWzRJ3GG5q+KdkD8b4NrtCDSfOeb/UtOpuZTxvuFkMDKCy1APpNJv 9RekupqvMrTbA6uvzFKxfP1GkDIqTbJQZpDmLq6iHYmPQr2/iIPE4Xc8uPKRDBjVr/1EAFzwO T+qU50225s3XzY47jDYRv6d2NKQtKOGDjkycuCSvFONcaqbjKJwniBIS+SfWjnlmhVEpjMpKM ONGpbgcrOu5f120f6c1cfPKudUnsgF4me2X4UqzUJM3AnoWahT+NPlNuk0j3xPJQn8x1tlvy8 Yg2hp56LuieSraruU1rEVOjWQqKUY9yVWhmPgso9U9lduiiVlb3tK07ijhw/o8chGcbj3e1lk ClDXIAdqmngtUhyzXQ0/Q23HCRiXEpX8dQtVr2nnOPhZiMX3bKO19cuWRGkLGkTTv1nm98a1C envcWLbmkG3E2wbXYGopZLq4hbWxgCuKiYbvbjv6O7Gn3YxlYCNlaF6ZdIvsmAY6xj0TwfxcC soSKLOcOzvKziA6+u/F4eYQNiIpf68tafgMLeWtuqm3JKikx4mY2jQOWGIq2AqqsWyAfHHbK8 NoPJc0fnE2fA/8pC80FVVTtbX5/WN8L6TOfDW0aIZhRk7/uBbC/6nri8mbkMmBbvcpym1yicT svVljJ0sUk/uks280sYtKBRLuV5m9oFlQp5g1FbTODI96kKjP5lTbHOOisPoMbAsnQbX3c6xu j8esHOo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 08:18:10 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/nicstar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 50dec13..96062e1 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -862,7 +862,7 @@ static scq_info *get_scq(ns_dev *card, int size, u32 scd) if (size != VBR_SCQSIZE && size != CBR_SCQSIZE) return NULL; - scq = kmalloc(sizeof(scq_info), GFP_KERNEL); + scq = kmalloc(sizeof(*scq), GFP_KERNEL); if (!scq) return NULL; scq->org = dma_alloc_coherent(&card->pcidev->dev, -- 2.10.0