From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Tony Krowiak <akrowiak@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: jjherne@linux.ibm.com, pasic@linux.ibm.com,
borntraeger@linux.ibm.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, david@redhat.com
Subject: Re: [PATCH v2 3/3] s390/vfio-ap: improve reaction to response code 07 from PQAP(AQIC) command
Date: Thu, 26 Oct 2023 10:15:11 -0400 [thread overview]
Message-ID: <0bed3d29-7fb1-d56d-5f12-e2010ae7d97f@linux.ibm.com> (raw)
In-Reply-To: <20231018133829.147226-4-akrowiak@linux.ibm.com>
On 10/18/23 9:38 AM, Tony Krowiak wrote:
> Let's improve the vfio_ap driver's reaction to reception of response code
> 07 from the PQAP(AQIC) command when enabling interrupts on behalf of a
> guest:
>
> * Unregister the guest's ISC before the pages containing the notification
> indicator bytes are unpinned.
>
> * Capture the return code from the kvm_s390_gisc_unregister function and
> log a DBF warning if it fails.
>
> Suggested-by: Matthew Rosato <mjrosato@linux.ibm.com>
> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
I went back-and-forth on whether this should be a stable/fixes candidate but I think no... I happened to notice it while reviewing other code, I'm not aware that it's ever created a visible issue, and it's on a pretty immediate error path. If anyone thinks it should be a stable candidate I have no objection but in that case would suggest to break the patch up to separate the new WARN from the fix.
next prev parent reply other threads:[~2023-10-26 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 13:38 [PATCH v2 0/3] a couple of corrections to the IRQ enablement function Tony Krowiak
2023-10-18 13:38 ` [PATCH v2 1/3] s390/vfio-ap: unpin pages on gisc registration failure Tony Krowiak
2023-10-26 12:18 ` Christian Borntraeger
2023-10-26 13:16 ` Tony Krowiak
2023-10-26 13:25 ` Christian Borntraeger
2023-10-26 14:20 ` Tony Krowiak
2023-10-18 13:38 ` [PATCH v2 2/3] s390/vfio-ap: set status response code to 06 " Tony Krowiak
2023-10-27 10:56 ` Halil Pasic
[not found] ` <8eb41445-1eff-4da7-830f-156f420afd5d@linux.ibm.com>
[not found] ` <20231027160347.05c6cd60.pasic@linux.ibm.com>
2023-10-27 17:06 ` Tony Krowiak
2023-10-18 13:38 ` [PATCH v2 3/3] s390/vfio-ap: improve reaction to response code 07 from PQAP(AQIC) command Tony Krowiak
2023-10-26 14:15 ` Matthew Rosato [this message]
2023-10-26 18:18 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bed3d29-7fb1-d56d-5f12-e2010ae7d97f@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox