From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+3d92cfcfa84070b0a470@syzkaller.appspotmail.com>,
io-uring@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernel?] KASAN: slab-use-after-free Read in thread_group_cputime
Date: Fri, 10 Jan 2025 14:32:24 +0000 [thread overview]
Message-ID: <0bef178c-bb78-4afb-b144-fa2f733c173b@gmail.com> (raw)
In-Reply-To: <8bcf5df2-91b9-4675-8305-77aa7ad999c8@kernel.dk>
On 1/10/25 14:13, Jens Axboe wrote:
> On 1/10/25 7:13 AM, Pavel Begunkov wrote:
>> On 1/10/25 13:56, Dmitry Vyukov wrote:
>>> On Fri, 10 Jan 2025 at 14:51, syzbot
>>> <syzbot+3d92cfcfa84070b0a470@syzkaller.appspotmail.com> wrote:
...
>>> #syz set subsystems: io-uring
>>>
>>> +maintainers
>>
>> Thanks. It probably needs something like below.
>>
>> diff --git a/io_uring/sqpoll.c b/io_uring/sqpoll.c
>> index 6df5e649c413..5768e31e99b1 100644
>> --- a/io_uring/sqpoll.c
>> +++ b/io_uring/sqpoll.c
>> @@ -268,8 +268,12 @@ static int io_sq_thread(void *data)
>> DEFINE_WAIT(wait);
>>
>> /* offload context creation failed, just exit */
>> - if (!current->io_uring)
>> + if (!current->io_uring) {
>> + mutex_lock(&sqd->lock);
>> + sqd->thread = NULL;
>> + mutex_unlock(&sqd->lock);
>> goto err_out;
>> + }
>>
>> snprintf(buf, sizeof(buf), "iou-sqp-%d", sqd->task_pid);
>> set_task_comm(current, buf);
>
> Indeed - can you send that out and I can include it in this weeks pull?
Done
--
Pavel Begunkov
next prev parent reply other threads:[~2025-01-10 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 13:51 [syzbot] [kernel?] KASAN: slab-use-after-free Read in thread_group_cputime syzbot
2025-01-10 13:56 ` Dmitry Vyukov
2025-01-10 14:13 ` Pavel Begunkov
2025-01-10 14:13 ` Jens Axboe
2025-01-10 14:32 ` Pavel Begunkov [this message]
2025-01-10 14:14 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bef178c-bb78-4afb-b144-fa2f733c173b@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dvyukov@google.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+3d92cfcfa84070b0a470@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox