From: Stephen Boyd <sboyd@kernel.org>
To: Li Chen <me@linux.beauty>
Cc: michael turquette <mturquette@baylibre.com>,
li chen <lchen@ambarella.com>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: create write_enable file to control clk rate write and other dangerous ops permission
Date: Thu, 12 Jan 2023 11:18:11 -0800 [thread overview]
Message-ID: <0c19d8dedda3e308c75a6c97358d2af3.sboyd@kernel.org> (raw)
In-Reply-To: <185a3f0a326.b623e6bd1243489.6765528573167668508@linux.beauty>
Quoting Li Chen (2023-01-11 19:05:34)
> Hi Stephen,
> ---- On Thu, 12 Jan 2023 02:37:29 +0800 Stephen Boyd wrote ---
> > Quoting Li Chen (2023-01-10 03:45:39)
> > > From: Li Chen lchen@ambarella.com>
> > >
> > > It's common requirement for bsp debug/test to change clk rate from userspace.
> > >
> > > Currently, we must define CLKOCK_ALLOW_WRITE_DEBUGFS then re-compile kernel
> > > to allow this feature. Let's replace it with a "write_enable" file to
> > > allow enable it at runtime.
> >
> > Nak. This design is intentional.
>
> Thanks for your reply. Got it. But sometimes re-compile is somewhat low efficient. Is it acceptable to provide
> a write_enable to clk_core(not enable by default), and allow clk driver to enable it inside clk_ops->init
> via clk_hw->core->write_enable = 1?
>
No
prev parent reply other threads:[~2023-01-12 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 11:45 [PATCH] clk: create write_enable file to control clk rate write and other dangerous ops permission Li Chen
2023-01-11 18:37 ` Stephen Boyd
2023-01-12 3:05 ` Li Chen
2023-01-12 19:18 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c19d8dedda3e308c75a6c97358d2af3.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=lchen@ambarella.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@linux.beauty \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox